sys/vfs: Drop dependency to posix headers#19501
Closed
maribu wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
sys/vfs: Drop dependency to posix headers#19501maribu wants to merge 1 commit intoRIOT-OS:masterfrom
maribu wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
maribu
added
the
CI: ready for build
maribu
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: Kconfig
maribu
force-pushed
the
sys/vfs/fix_deps
branch
2 times, most recently
from
aa1d4eb to
7942b3c
Compare
maribu
commented
Apr 24, 2023
Comment on lines
+68
to
+69
| #ifdef CPU_NATIVE | ||
| /* on native, use system's struct statvfs definition */ |
Member
Author
There was a problem hiding this comment.
This IMO also supports @chrysn assessment that we shouldn't reuse POSIX types for RIOT's native non-POSIX VFS API.
maribu
force-pushed
the
sys/vfs/fix_deps
branch
from
7942b3c to
8ed5d32
Compare
Our POSIX compat layer provides POSIX compatible VFS stats based on RIOT VFS module. Consequently, the POSIX layer should depend on VFS, rather than VFS depending on POSIX. This moves a struct definition to the VFS module headers and lets the POSIX compatibility layer include `vfs.h`, rather than `vfs.h` including the POSIX compat headers.
maribu
force-pushed
the
sys/vfs/fix_deps
branch
from
8ed5d32 to
7362ccc
Compare
Member
Author
|
This doesn't seem to result in a quick fix I was hoping for, as VFS is to closely entangled with POSIX definitions (e.g. I guess there should rather be a discussion on whether we should evolve RIOT's VFS to a RIOT specific API without regard for POSIX, and a POSIX layer on top, or if we should stick with the current approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Our POSIX compat layer provides POSIX compatible VFS stats based on RIOT VFS module. Consequently, the POSIX layer should depend on VFS, rather than VFS depending on POSIX.
This moves a struct definition to the VFS module headers and lets the POSIX compatibility layer include
vfs.h, rather thanvfs.hincluding the POSIX compat headers.Testing procedure
Green CI and binaries (except for debug symbols) shouldn't change.
Issues/PRs references
#19495 (comment)