nanocoap: implement extended tokens (RFC 8974)#19487
Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom Jul 7, 2023
Merged
nanocoap: implement extended tokens (RFC 8974)#19487bors[bot] merged 2 commits intoRIOT-OS:masterfrom
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
github-actions
bot
added
Area: CoAP
benpicco
force-pushed
the
nanocoap_token_ext
branch
from
3ffac49 to
3bc5a43
Compare
Teufelchen1
approved these changes
Apr 27, 2023
Member
|
Unless there's any hurry, plz hold merging, I'd like to review.
|
benpicco
force-pushed
the
nanocoap_token_ext
branch
from
fa56b4d to
1ce7121
Compare
Contributor
Author
|
As this would needlessly add 348 bytes of ROM even when not used, I hid it behind a |
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
nanocoap_token_ext
branch
from
1ce7121 to
c01c470
Compare
Contributor
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 7, 2023
19487: nanocoap: implement extended tokens (RFC 8974) r=benpicco a=benpicco
19781: cpu/nrf{53,9160}: add pwm support r=benpicco a=dylad
### Contribution description
This PR moves the nRF52 PWM driver to `cpu/nrf5x_common` to allow nRF9160 and nRF53 to use this driver.
IP is identical on these families.
I didn't test on nRF9160DK and I didn't test if there is any regression on nRF52-based board as I don't have any so tests are welcome !
However it works fine on nRF53-based board.
### Testing procedure
Flash the `tests/periph/pwm` test application on `nrf5340dk` or `nrf9160dk`.
You can then use the `osci` command to make the onboard LEDs "breath".
You can also attach an oscilloscope and/or logic analyzer to watch the signal.
### Issues/PRs references
~~Based on #19769~~
Co-authored-by: Benjamin Valentin <[email protected]>
Co-authored-by: Dylan Laduranty <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
RFC8974 allows for token length of up to 65804 Byte in order to store Client state in the token.
This is easy to implement in nanoCoAP, so let's give it a try.
Testing procedure
Currently no use case is associated with this, but I extended the unit test.
Maybe we should only enable this when a pseudo-module
nanocoap_token_extis used.Issues/PRs references