cpu/stm32/periph_gpio_ll: Fix misleading comments#19454
Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom Apr 9, 2023
Merged
cpu/stm32/periph_gpio_ll: Fix misleading comments#19454bors[bot] merged 1 commit intoRIOT-OS:masterfrom
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
Conversation
maribu
requested review from
DipSwitch,
aabadie,
fjmolinas and
vincent-d
as code owners
github-actions
bot
added
Area: cpu
maribu
added
Type: bug
The comments still claim STM32F1 support is missing, but this was recently added. Also, drop an empty line to fix `too many consecutive empty lines` nitpick of the CI.
maribu
force-pushed
the
cpu/stm32/periph/gpio_ll_fix_doc
branch
from
e1ddf54 to
dd86da6
Compare
gschorcht
added
the
CI: skip compile test
Contributor
|
bors merge |
Contributor
|
Build succeeded:
|
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The comments still claim STM32F1 support is missing, but this was recently added.
Also, drop an empty line to fix
too many consecutive empty linesnitpick of the CI.Testing procedure
This since only changes comments, this won't effect the binaries. Technically, those comments would be Doxygen compatible comments. But as only Doxygen comments in headers are parsed, these are in practice regular plain comments.
Issues/PRs references
#19407 added basic GPIO LL support for STM32F1, #19412 added the IRQ support on top of that.