Skip to content

boards/esp*: complete SD Card MTD config#19255

Merged
bors[bot] merged 3 commits intoRIOT-OS:masterfrom
gschorcht:boards/esp/complete_sd_card_mtd_config
Feb 7, 2023
Merged

boards/esp*: complete SD Card MTD config#19255
bors[bot] merged 3 commits intoRIOT-OS:masterfrom
gschorcht:boards/esp/complete_sd_card_mtd_config

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Feb 6, 2023

Contribution description

This PR provides the remaining changes necessary to use the generic MTD SD Card configuration as described in PR #19216.

This includes defining the MTD offset for SD cards, since the default MTD_0 device always uses the internal flash device, and the completion of the configuration for the ESP32 boards with a SD card interface.

Testing procedure

tests/vfs_default should work now with SD Cards:

main(): This is RIOT! (Version: 2023.04-devel-323-gfcc07)
mount points:
	/nvm0
	/sd0

data dir: /sd0
> vfs df 
Mountpoint              Total         Used    Available     Use%
/nvm0                3052 KiB        8 KiB     3044 KiB       0%
/sd0                 7580 MiB 3632148992 B   21089792 B      99%

Issues/PRs references

@gschorcht
boards/common/esp*: set MTD offset for SD Cards to 1
967ec44 
Since the default MTD device `MTD_0` is the internal flash on ESP32x SoCs, SD card devices have to start at `MTD_1`.
@gschorcht
boards/esp32-wrover-kit: complete SD card MTD config
6477976
@github-actions github-actions bot added Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration labels Feb 6, 2023
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Feb 6, 2023
@gschorcht gschorcht requested a review from benpicco February 6, 2023 22:51
@riot-ci
Copy link
Copy Markdown

riot-ci commented Feb 6, 2023 •
edited
Loading

Murdock results

✔️ PASSED

43a92ed boards/esp32-wemos-lolin-d32-pro: complete SD card MTD config

Success Failures Total Runtime
6850 0 6851 10m:58s

Artifacts

@gschorcht gschorcht force-pushed the boards/esp/complete_sd_card_mtd_config branch from ad909aa to 43a92ed Compare February 7, 2023 00:20
@github-actions github-actions bot removed the Platform: ESP Platform: This PR/issue effects ESP-based platforms label Feb 7, 2023
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Feb 7, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Feb 7, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Feb 7, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Feb 7, 2023

Build succeeded:

@bors bors bot merged commit dd2d336 into RIOT-OS:master Feb 7, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
@gschorcht gschorcht deleted the boards/esp/complete_sd_card_mtd_config branch May 29, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2023.04

Development

Successfully merging this pull request may close these issues.

4 participants

@gschorcht @riot-ci @benpicco @MrKevinWeiss