pkg/tinydtls: drop libc_gettimeofday dependency#19247
Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom Feb 28, 2023
Merged
pkg/tinydtls: drop libc_gettimeofday dependency#19247bors[bot] merged 2 commits intoRIOT-OS:masterfrom
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
Conversation
benpicco
force-pushed
the
pkg/tinydtls-gettimeofday
branch
from
50622a5 to
5c81e28
Compare
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
pkg/tinydtls-gettimeofday
branch
from
5c81e28 to
ff0b979
Compare
Contributor
Author
|
Dropped the patch to tinydtls as it has been merged upstream. |
Contributor
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 27, 2023
17612: pkg: add FlashDB r=benpicco a=benpicco 19247: pkg/tinydtls: drop libc_gettimeofday dependency r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
Author
|
bors merge |
Contributor
|
Already running a review |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
gettimeofday()(viatime()) is only used to print timestamps in the debug output.We don't need this, use our own debug functions without the expensive timestamp.
With this, we can drop the requirement to include
libc_gettimeofday.Testing procedure
before
Code should still compile
with this patch
Issues/PRs references
upstream PR eclipse-tinydtls/tinydtls#187