drivers/mtd_sdcard: add mtd_sdcard_default module#19216
drivers/mtd_sdcard: add mtd_sdcard_default module#19216bors[bot] merged 7 commits intoRIOT-OS:masterfrom
Conversation
|
Kconfig changes for the affected boards and the driver are missing. |
|
BTW, while crawling through the dependencies, I wonder why some of these boards provide a feature |
|
Kconfig should probably be cleaned up a bit with this PR. We have |
Was your reaction really to be understood as being confused or surprised? |
|
I'm not surprised, just not very enthusiastic about it 😅 |
We should definitely define an |
19193: rust: Update dependencies, use riot-wrappers from git r=benpicco a=chrysn ### Contribution description As riot-wrappers has advanced a bit since it was last released, Rust modules are switched to using it from git again. (This is a regular ping-pong between testing the latest release in RIOT master, and using released support crates when they're current). This primarily updates riot-wrappers, which has accumulated several compatible changes. Several other crates receive updates as well. ### Testing procedure * Green CI ### Issues/PRs references Changes on the riot-wrappers side: * RIOT-OS/rust-riot-wrappers#17 * RIOT-OS/rust-riot-wrappers#22 * RIOT-OS/rust-riot-wrappers#29 * RIOT-OS/rust-riot-wrappers#30 [edit: added:] This also serves to help preparing a 0.8.1 release of riot-wrappers, which performs some deprecations so that a breaking 0.9 change can be done more effortlessly later on. 19214: cpu/gd32v: add periph_spi support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_spi` support and is one of a bunch of PRs that complete the peripheral drivers for GD32VF103. The driver is a modified version of the driver for STM32F1 with some changes that were necessary to get it working on GD32V. ### Testing procedure `tests/periph_spi` as well as a test with any SPI sensor should work. `tests/driver_sdcard_spi` should work on `sipeed-longan-nano`. ### Issues/PRs references Depeneds on PR #19216 Co-authored-by: chrysn <[email protected]> Co-authored-by: Gunar Schorcht <[email protected]>
bf12577 to
0284e61
Compare
|
Already works on |
|
bors try |
tryBuild failed: |
|
Hm, the Kconfig issues still remain 😉 |
|
Yea I just wanted to see what fails |
0284e61 to
02a15a0
Compare
tryBuild failed: |
👍 Yes, but still requires the Kconfig changes 😉 |
That's why I hadn't approved it yet. |
| nucleo-f302r8 \ | ||
| saml10-xpro \ | ||
| saml11-xpro \ | ||
| sipeed-longan-nano \ |
There was a problem hiding this comment.
Unfortunately, this board has not enough memory 😟
There was a problem hiding this comment.
Yea you can only have either nanocoap_vfs or nanocoap_dtls on this one.
tryBuild succeeded: |
|
Looks like CI is happy, should I squash? 😇 |
|
Congratulations 🚀 Yes, please squash. |
c6f9cee to
f78cdbb
Compare
|
bors merge |
19088: boards: add esp32s3-pros3 support r=benpicco a=gschorcht ### Contribution description This PR provides the support for [ESP32 ProS3](https://esp32s3.com/pros3.html#home) board from Unexpected Maker. This board doesn't have a USB-to-Serial chip on board. Therefore, USB Serial/JTAG is used for STDIO and the board is flashed via the USB Seral/JTAG interface by default. ### Testing procedure Flashing `tests/shell` should work. ### Issues/PRs references 19216: drivers/mtd_sdcard: add mtd_sdcard_default module r=benpicco a=benpicco Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>
|
Build failed (retrying...): |
|
Unrelated error bors merge |
|
Already running a review |
|
Build succeeded: |
19240: tools/doccheck: add simple exclude to doccheck r=benpicco a=kfessel while doccheck runs for #19228 and #19220, i saw some spikes in memory consumption, turned out that was `grep -Evf dist/tools/doccheck/exclude_patterns` using about 2GB RAM. This PR changes that. ### Contribution description add `exclude_simple` to `doccheck` drived from `exclude patterns` `sort`ed and `uniq`ued the simple excludes removes no longer needed patterns from `exclude patterns` simple excludes are string rules (no patterns just strings) how to apply these: in this PR: *remove the path and line number from the rule * that made some of them doubles of each other * sorted and uniqued them. * this set of excludes is no longer path specific (an exception covers all paths but may of them still contain a file name) another possible solution would be to have the excludes line number specific. ### Testing procedure run `dist/tools/doccheck/check.sh` compare memory consumption of master: `grep -Evf dist/tools/doccheck/exclude_patterns` to this PR: `grep -Fvf dist/tools/doccheck/exclude_simple` ### Issues/PRs references 19248: cpu/gd32v: add periph_dac support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_dac` support for GD32VF103. ### Testing procedure `tests/periph_dac` should work on `sipeed-longan-nano` port on PA4 and PA5. ### Issues/PRs references 19255: boards/esp*: complete SD Card MTD config r=benpicco a=gschorcht ### Contribution description This PR provides the remaining changes necessary to use the generic MTD SD Card configuration as described in PR #19216. This includes defining the MTD offset for SD cards, since the default `MTD_0` device always uses the internal flash device, and the completion of the configuration for the ESP32 boards with a SD card interface. ### Testing procedure `tests/vfs_default` should work now with SD Cards: ``` main(): This is RIOT! (Version: 2023.04-devel-323-gfcc07) mount points: /nvm0 /sd0 data dir: /sd0 > vfs df Mountpoint Total Used Available Use% /nvm0 3052 KiB 8 KiB 3044 KiB 0% /sd0 7580 MiB 3632148992 B 21089792 B 99% ``` ### Issues/PRs references Co-authored-by: Karl Fessel <[email protected]> Co-authored-by: Gunar Schorcht <[email protected]>
Contribution description
Copy & pasting MTD SDCard config between boards gets old really quick.
Provide the generic config via the
mtd_sdcard_defaultmodule so the boards don't have to provide it anymore.Testing procedure
tests/vfs_defaultshould still work on any of the affected boards.Issues/PRs references