Skip to content

drivers/rtc: mark as legacy#1919

Closed
LudwigKnuepfer wants to merge 3 commits intoRIOT-OS:masterfrom
LudwigKnuepfer:rtc_legacy
Closed

drivers/rtc: mark as legacy#1919
LudwigKnuepfer wants to merge 3 commits intoRIOT-OS:masterfrom
LudwigKnuepfer:rtc_legacy

Conversation

@LudwigKnuepfer
Copy link
Copy Markdown
Member

  • rename interface
  • add @deprecated
  • also: fix missing @author and @file

@LudwigKnuepfer LudwigKnuepfer added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: doc Area: Documentation Area: drivers Area: Device drivers labels Oct 31, 2014
@OlegHahm
Copy link
Copy Markdown
Member

Wouldn't it adapt these two platforms to the new API? It seems to be mostly function renaming.

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

It's definitely more work than I was willing to put into this for now.
But of course, the goal is to transition to the new interfaces and purge the deprecated ones.

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

By the way - there currently is not a single implementation of the periph/rtc.h interface in master.

@OlegHahm
Copy link
Copy Markdown
Member

It's definitely more work than I was willing to put into this for now.
But of course, the goal is to transition to the new interfaces and purge
the deprecated ones.

From a brief look it appeared not much more effort than the current PR, since the interfaces look quite similar, but of course I have not checked in detail (where the devil might wait for you).

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

I have - the interfaces themselves are not even the hairy part.
There is no tests/periph_rtc, no sys/shell/commands/periph_rtc.c, ...

@mehlis
Copy link
Copy Markdown
Contributor

mehlis commented Nov 5, 2014

@OlegHahm this RTC implementation on msba2 was the only thing in RIOT which was working from the beginning of my thesis:)

but +1 to deprecate it now and remove it with the release after the next one.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Nov 5, 2014

There's a sc_rtc.c.

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

I'm not going to add anything to this PR in the immediate future.

@OlegHahm if you think it's a bad idea to deprecate it just say so, otherwise I suggest merging this now and taking care of the rewrite in a different PR.

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

@OlegHahm ping - if you don't want this let's close it - if you want it changed say so.

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

(or you could just decide you don't care..)

@OlegHahm
Copy link
Copy Markdown
Member

As I said: I would prefer adapting to the new API over deprecating the old one, but I'm not against it - and haven't looked how difficult the actual task is, so far.

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

Superseded by #2060

@LudwigKnuepfer LudwigKnuepfer deleted the rtc_legacy branch November 26, 2014 10:00
@LudwigKnuepfer LudwigKnuepfer restored the rtc_legacy branch November 26, 2014 10:00
@LudwigKnuepfer LudwigKnuepfer deleted the rtc_legacy branch November 26, 2014 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation Area: drivers Area: Device drivers Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants