boards: common: stdio_cdc_acm: let tests wait a bit for serial port#19128
Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom Jan 12, 2023
Merged
boards: common: stdio_cdc_acm: let tests wait a bit for serial port#19128bors[bot] merged 2 commits intoRIOT-OS:masterfrom
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
Conversation
Member
Author
See https://github.com/RIOT-OS/RIOT/actions/runs/3892598987. The one to look for is |
Contributor
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Member
Author
|
The ESP issues seem unrelated but they show up :-/. |
Member
Author
cc83f44 to
64bea31
Compare
Member
Author
|
Deactivated tests for now. The tests this touches worked and the failing tests fail in master as well. |
Contributor
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19128: boards: common: stdio_cdc_acm: let tests wait a bit for serial port r=aabadie a=miri64 Co-authored-by: Martine Lenders <[email protected]>
Contributor
|
Build failed: |
Member
Author
|
bors retry |
Member
Author
|
bors merge |
Contributor
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19128: boards: common: stdio_cdc_acm: let tests wait a bit for serial port r=aabadie a=miri64 19133: makefiles/utils/strings.mk: Fix version_is_greater_or_equal r=maribu a=maribu ### Contribution description The Makefile function `version_is_greater_or_equal` is used to check if a version of GNU Make is at least the required one. However, it has the built-in assumption the version numbers have to format x.y.z, but Alpine Linux currently ships GNU Make 4.4. This results in `$(call _pad_number,3,)` which runs `printf '$03d' ''` in the shell, which is not valid. This fixes the issue by making `_pad_number` more robust by fall back to printing `0` with the given padding, if the number given to print is empty. ### Testing procedure Append ```Makefile $(info A=$(call version_is_greater_or_equal,4.2.0,4.2.0)) $(info B=$(call version_is_greater_or_equal,4.2,4.2.0)) $(info C=$(call version_is_greater_or_equal,4.1,4.2.0)) $(info D=$(call version_is_greater_or_equal,4.1.9,4.2.0)) $(info E=$(call version_is_greater_or_equal,5.1.9,4.2.0)) $(info F=$(call version_is_greater_or_equal,5.0.0,4.2.0)) $(info G=$(call version_is_greater_or_equal,4.2.1,4.2.0)) $(info H=$(call version_is_greater_or_equal,4.3.1,4.2.0)) ``` e.g. to `makefiles/utils/strings.mk`, build something and observe the info output. This yields ``` A=1 B=1 C= D= E=1 F=1 G=1 H=1 ``` for me and does not complain about invalid `printf` invocations. ### Issues/PRs references None Co-authored-by: Martine Lenders <[email protected]> Co-authored-by: Marian Buschsieweke <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19128: boards: common: stdio_cdc_acm: let tests wait a bit for serial port r=aabadie a=miri64 Co-authored-by: Martine Lenders <[email protected]>
Contributor
|
Build failed: |
Member
|
bors retry |
Contributor
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
19143: boards: common: stdio_cdc_acm: let tests wait a bit for serial port [backport 2023.01] r=kaspar030 a=kaspar030 # Backport of #19128 Co-authored-by: Martine Lenders <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
19143: boards: common: stdio_cdc_acm: let tests wait a bit for serial port [backport 2023.01] r=kaspar030 a=kaspar030 # Backport of #19128 19144: shell/rtc: Fix out of bounds access; document error behavior [backport 2023.01] r=kaspar030 a=kaspar030 # Backport of #19141 ### Contribution description ### Testing procedure Should be trivial enough, especially as the difference is hard to spot interactively. On native, run the default example (and wait for the traffic to settle). Then, run ``` > rtc poweron > rtc settime 2022-01-01 00:00:00 > rtc settime 2022-99-01 00:00:00 ``` Both still work, but the latter doesn't access unassigned memory any more ### Issues/PRs references This fixes an issue that was submitted anonymously. Co-authored-by: Martine Lenders <[email protected]> Co-authored-by: chrysn <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
19143: boards: common: stdio_cdc_acm: let tests wait a bit for serial port [backport 2023.01] r=kaspar030 a=kaspar030 # Backport of #19128 Co-authored-by: Martine Lenders <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jan 14, 2023
19143: boards: common: stdio_cdc_acm: let tests wait a bit for serial port [backport 2023.01] r=kaspar030 a=kaspar030 # Backport of #19128 Co-authored-by: Martine Lenders <[email protected]>
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 4, 2023
After a reset, it can take several seconds before the CDC ACM interface becomes available as serial device `ttyACMx`. This was a change that was already made for `stdio_cdc_acm` in RIOT-OS#19128.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 4, 2023
After a reset, it can take several seconds before the CDC ACM interface becomes available as serial device `ttyACMx`. This was a change that was already made for `stdio_cdc_acm` in RIOT-OS#19128.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 6, 2023
After a reset, it can take several seconds before the CDC ACM interface becomes available as serial device `ttyACMx`. This was a change that was already made for `stdio_cdc_acm` in RIOT-OS#19128.
zhaolanhuang
pushed a commit
to zhaolanhuang/RIOT
that referenced
this pull request
Dec 6, 2023
After a reset, it can take several seconds before the CDC ACM interface becomes available as serial device `ttyACMx`. This was a change that was already made for `stdio_cdc_acm` in RIOT-OS#19128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Some tests may fail spuriously with
stdio_cdc_acm, since thettymight not exist yet. This configures a small delay after resetting fortestutilsand also piggybacks the honoring of that delay for theriotctrl-based tests.Testing procedure
CI should pass all tests. Maybe we should also run
tests-on-iotlabfor this PR.Issues/PRs references
None