boards: add esp32s3-pros3 support by gschorcht · Pull Request #19088 · RIOT-OS/RIOT

gschorcht · 2023-01-04T01:15:53Z

Contribution description

This PR provides the support for ESP32 ProS3 board from Unexpected Maker.

This board doesn't have a USB-to-Serial chip on board. Therefore, USB Serial/JTAG is used for STDIO and the board is flashed via the USB Seral/JTAG interface by default.

Testing procedure

Flashing tests/shell should work.

Issues/PRs references

benpicco · 2023-01-14T23:07:54Z

Does stdio_usb_serial_jtag work on this one?

gschorcht · 2023-01-15T10:04:53Z

Does stdio_usb_serial_jtag work on this one?

Yes. So it seems to be better to use stdio_usb_serial_jtag by default to let the application the option to use USBUS or tinyUSB. Was that the background of your question?

benpicco · 2023-01-15T10:51:26Z

Yes because it should only require a single USB cable then, right? Because Serial/JTAG is a dedicated USB port and device USB would be on another one.

So if the user only has to connect to a single port for flashing and the shell, that would be more convenient.

edit oh I see the board only has a single USB.
How does that work? Can Serial/JTAG and device USB be switched at run-time?

gschorcht · 2023-01-15T11:07:45Z

edit oh I see the board only has a single USB.
How does that work? Can Serial/JTAG and device USB be switched at run-time?

Yeah, that's a bit tricky 😉 The ESP32S3 has two different controllers but a logic which one is routed to the D+/D- pin, see ESP32S3 TRM page 1204. On reset, the USB Serial/JTAG interface is selected by default so that you can flash and use the CDC ACM interface. If the USB OTG is initialized, the USB OTG signals are selected and the USB Serial/JTAG interface is not available any longer.

benpicco · 2023-01-18T12:41:42Z

That's interesting.
Yea I think stdio_usb_serial_jtag would be a good default since it should be more robust and light-weight as it acts more like a USB-UART adapter than a full USB stack.

But I'm mainly asking if it works on ESP32-S3 at all, I only received one in the mail today.

Btw: What's still WIP here?

gschorcht · 2023-02-03T22:56:43Z

Work on this board definition has been finished.

riot-ci · 2023-02-04T12:24:09Z

Murdock results

✔️ PASSED

90dc95e boards/common/stdio_tinyusb_cdc_acm: let tests wait for serial port

Success	Failures	Total	Runtime
6851	0	6851	09m:20s

Artifacts

Documentation preview

gschorcht · 2023-02-04T13:31:52Z

@benpicco I had to provide some fixes due to compilation error in Murdock:

The module usb_board_reset is also enabled when stdio_usb_serial_jtag is used as STDIO backend. Even if another STDIO backend like stdio_uart is flashed, the USB Serial/JTAG CDC ACM and thus a ttyACMx should be available. Although usb_board_reset doesn't affect the USB Serial/JTAG CDC ACM, it is necessary to be able to reset the board in download mode for flashing if stdio_cdc_acm or stdio_tinyusb_cdc_acm was previously flashed and is still active. Otherwise flashing via the USB Serial/JTAG CDC ACM interface is not possible. Commit 9f8b1e0 allows to enable usb_board_reset in Kconfig also if only stdio_usb_serial_jtag is used.
In PR boards: common: stdio_cdc_acm: let tests wait a bit for serial port #19128, a delay for tests was defined in stdio_cdc_acm.dep.mk to take into account the fact that it may take a few seconds before the CDC ACM serial device ttyACM becomes available. Commit 9810617 adds this change to stdio_tinyusb_cdc_acm.dep.mk.
Commit 97373d8 adds a comment for usb_board_reset and enables it in Kconfig.

benpicco

Looks good to me - please squash!

benpicco · 2023-02-05T18:31:16Z

bors merge

19088: boards: add esp32s3-pros3 support r=benpicco a=gschorcht ### Contribution description This PR provides the support for [ESP32 ProS3](https://esp32s3.com/pros3.html#home) board from Unexpected Maker. This board doesn't have a USB-to-Serial chip on board. Therefore, USB Serial/JTAG is used for STDIO and the board is flashed via the USB Seral/JTAG interface by default. ### Testing procedure Flashing `tests/shell` should work. ### Issues/PRs references 19216: drivers/mtd_sdcard: add mtd_sdcard_default module r=benpicco a=benpicco Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>

bors · 2023-02-05T19:29:51Z

Build failed (retrying...):

Murdock

19088: boards: add esp32s3-pros3 support r=benpicco a=gschorcht ### Contribution description This PR provides the support for [ESP32 ProS3](https://esp32s3.com/pros3.html#home) board from Unexpected Maker. This board doesn't have a USB-to-Serial chip on board. Therefore, USB Serial/JTAG is used for STDIO and the board is flashed via the USB Seral/JTAG interface by default. ### Testing procedure Flashing `tests/shell` should work. ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>

bors · 2023-02-05T20:30:09Z

Build failed:

Murdock

boards/esp32s3-pros3/Makefile.features

Even if only `stdio_usb_serial_jtag` is enabled as STDIO, `usb_board_reset` is enabled since there should be a CDC ACM interface in any case. This is necessary, for example, to reset the board into bootloader if `stdio_cdc_acm` or `stdio_tinyusb_cdc_acm` was previously used.

After a reset, it can take several seconds before the CDC ACM interface becomes available as serial device `ttyACMx`. This was a change that was already made for `stdio_cdc_acm` in RIOT-OS#19128.

benpicco · 2023-02-06T15:29:17Z

bors merge

bors · 2023-02-06T17:53:53Z

Build succeeded:

gschorcht · 2023-02-06T18:46:24Z

Thanks for reviewing and merging.

gschorcht requested review from MrKevinWeiss, jia200x and leandrolanzieri as code owners January 4, 2023 01:15

github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jan 4, 2023

gschorcht added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jan 4, 2023

gschorcht mentioned this pull request Jan 5, 2023

boards/hip-badge: add HiP Badge board definition #19076

Merged

12 tasks

gschorcht force-pushed the boards/esp32s3-pros3 branch 2 times, most recently from f3b3d26 to 8ae127d Compare January 5, 2023 07:41

gschorcht force-pushed the boards/esp32s3-pros3 branch from 8ae127d to c23585b Compare February 3, 2023 22:49

github-actions bot removed Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Feb 3, 2023

gschorcht removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Feb 3, 2023

github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Feb 3, 2023

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 4, 2023

benpicco approved these changes Feb 4, 2023

View reviewed changes

github-actions bot added Area: build system Area: Build system Area: sys Area: System labels Feb 4, 2023

benpicco approved these changes Feb 4, 2023

View reviewed changes

gschorcht force-pushed the boards/esp32s3-pros3 branch from 97373d8 to 22397e1 Compare February 4, 2023 14:50

benpicco reviewed Feb 6, 2023

View reviewed changes

boards/esp32s3-pros3/Makefile.features Show resolved Hide resolved

gschorcht added 3 commits February 6, 2023 16:19

boards: add support for ESP32 ProS3 board

df46c45

boards/common/stdio_tinyusb_cdc_acm: let tests wait for serial port

90dc95e

After a reset, it can take several seconds before the CDC ACM interface becomes available as serial device `ttyACMx`. This was a change that was already made for `stdio_cdc_acm` in RIOT-OS#19128.

gschorcht force-pushed the boards/esp32s3-pros3 branch from 22397e1 to 90dc95e Compare February 6, 2023 15:19

bors bot merged commit fcc07a5 into RIOT-OS:master Feb 6, 2023

gschorcht deleted the boards/esp32s3-pros3 branch February 6, 2023 18:47

MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023

Conversation

gschorcht commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

benpicco commented Jan 14, 2023

Uh oh!

gschorcht commented Jan 15, 2023

Uh oh!

benpicco commented Jan 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gschorcht commented Jan 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benpicco commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gschorcht commented Feb 3, 2023

Uh oh!

riot-ci commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

gschorcht commented Feb 4, 2023

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

benpicco commented Feb 5, 2023

Uh oh!

bors bot commented Feb 5, 2023

Uh oh!

bors bot commented Feb 5, 2023

Uh oh!

Uh oh!

benpicco commented Feb 6, 2023

Uh oh!

bors bot commented Feb 6, 2023

Uh oh!

gschorcht commented Feb 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gschorcht commented Jan 4, 2023 •

edited

Loading

benpicco commented Jan 15, 2023 •

edited

Loading

gschorcht commented Jan 15, 2023 •

edited

Loading

benpicco commented Jan 18, 2023 •

edited

Loading

riot-ci commented Feb 4, 2023 •

edited

Loading