Skip to content

CI: no quickbuild on "bors try"#19063

Merged
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
kaspar030:ci_bors_try_no_quickbuild
Dec 19, 2022
Merged

CI: no quickbuild on "bors try"#19063
bors[bot] merged 1 commit intoRIOT-OS:masterfrom
kaspar030:ci_bors_try_no_quickbuild

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Dec 17, 2022 •
edited by benpicco
Loading

Contribution description

Make "bors try" behave like "bors merge", don't do a quick build.

Testing procedure

  • regular PR build (should be a quickbuild): build
  • "bors try" (should be a full build) build
  • finally, "bors merge"

Issues/PRs references

fixes RIOT-OS/murdock-scripts#45

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 17, 2022
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Dec 17, 2022
@kaspar030 kaspar030 mentioned this pull request Dec 17, 2022
Open
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Dec 17, 2022

So this would still fast-fail on "bors try"...
IMO, as there is the option to do "CI: full build" and "CI: no fast fail" for regular PR builds, I'd prefer to actually have "bors try" be "bors merge but don't merge".
There's no (easy) way to control "bors try" (it doesn't know about PR labels).

@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Dec 17, 2022

bors try

bors bot added a commit that referenced this pull request Dec 17, 2022
@bors
Try #19063:
45719a0
@riot-ci
Copy link
Copy Markdown

riot-ci commented Dec 17, 2022

Murdock results

✔️ PASSED

a747fb3 CI: no quickbuild on "bors try"

Success Failures Total Runtime
2006 0 2006 04m:45s

Artifacts

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Dec 17, 2022

try

Build failed:

@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Dec 17, 2022

Build failed:

* [Murdock](https://ci.riot-os.org/details/6a994d3894e44fc2a34bcddd676e4e62)

this did build examples/default for >200 boards, so it was not a quick build.

@kaspar030 kaspar030 requested review from benpicco and maribu December 18, 2022 09:53
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Dec 18, 2022

bors merge

bors bot added a commit that referenced this pull request Dec 18, 2022
@bors @kaspar030
Merge #19063
38ff749 
19063: CI: no quickbuild on "bors try" r=kaspar030 a=kaspar030



Co-authored-by: Kaspar Schleiser <[email protected]>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Dec 18, 2022

Build failed:

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Dec 19, 2022

bors merge

bors bot added a commit that referenced this pull request Dec 19, 2022
@bors @jia200x
@Ollrogge @aabadie @kaspar030
Merge #18472 #18637 #19056 #19063
d88a1e5 
18472: drivers/mrf24j40: add support for IEEE 802.15.4 Radio HAL r=benpicco a=jia200x



18637: Fido2 follow up r=benpicco a=Ollrogge



19056: pkg/lvgl: bump to 8.3.4 r=aabadie a=aabadie



19063: CI: no quickbuild on "bors try" r=aabadie a=kaspar030



Co-authored-by: Jose Alamos <[email protected]>
Co-authored-by: Ollrogge <[email protected]>
Co-authored-by: Alexandre Abadie <[email protected]>
Co-authored-by: Kaspar Schleiser <[email protected]>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Dec 19, 2022

Build failed (retrying...):

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Dec 19, 2022

Build succeeded:

@bors bors bot merged commit 0c157b7 into RIOT-OS:master Dec 19, 2022
@kaspar030 kaspar030 deleted the ci_bors_try_no_quickbuild branch February 6, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees

No one assigned

Labels

Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow on-demand full build with bors

4 participants

@kaspar030 @riot-ci @aabadie @maribu