drivers/at86rf2xx: isolate netdev logic#18988
Merged
benpicco merged 13 commits intoRIOT-OS:masterfrom Dec 7, 2022
Merged
Conversation
jia200x
force-pushed
the
pr/at86rf2xx/isolate_netdev
branch
from
19dcb76 to
a544b98
Compare
Member
Author
|
This PR is technically an API change, because I removed several functions (getters, |
jia200x
added
the
Type: cleanup
jia200x
force-pushed
the
pr/at86rf2xx/isolate_netdev
branch
from
a544b98 to
f34695f
Compare
jia200x
added
the
CI: ready for build
jia200x
force-pushed
the
pr/at86rf2xx/isolate_netdev
branch
from
83f27d0 to
fa61430
Compare
benpicco
reviewed
Dec 6, 2022
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Just moves code around, solid cleanup.
Some small comments:
drivers/at86rf2xx/at86rf2xx_getset.c
Outdated
| @@ -363,7 +363,6 @@ void at86rf2xx_set_option(at86rf2xx_t *dev, uint16_t option, bool state) | |||
| DEBUG("[at86rf2xx] opt: enabling CSMA mode" \ | |||
| "(4 retries, min BE: 3 max BE: 5)\n"); | |||
| /* Initialize CSMA seed with hardware address */ | |||
Contributor
There was a problem hiding this comment.
The comment needs to be moved too
| #ifdef MODULE_SIXLOWPAN | ||
| /* https://tools.ietf.org/html/rfc4944#section-12 requires the first bit to | ||
| * 0 for unicast addresses */ | ||
| dev->netdev.short_addr[0] &= 0x7F; |
Contributor
There was a problem hiding this comment.
netdev_eui64_get() should already take care of this
Member
Author
Contributor
There was a problem hiding this comment.
Alright, if you are getting rid of this anyway you might as well keep it.
Comment on lines
+276
to
286
| netdev_ieee802154_reset(&dev->netdev); | ||
| /* set short and long address */ | ||
| at86rf2xx_set_addr_long(dev, (eui64_t *)dev->netdev.long_addr); | ||
| at86rf2xx_set_addr_short(dev, (network_uint16_t *)dev->netdev.short_addr); | ||
|
|
||
| if (!IS_ACTIVE(AT86RF2XX_BASIC_MODE)) { | ||
| static const netopt_enable_t enable = NETOPT_ENABLE; | ||
| netdev_ieee802154_set(&dev->netdev, NETOPT_ACK_REQ, | ||
| &enable, sizeof(enable)); | ||
| } | ||
| at86rf2xx_reset(dev); |
Contributor
There was a problem hiding this comment.
maybe just call _init() here (btw: is NETOPT_STATE_RESET even used by anything?)
Member
Author
Contributor
There was a problem hiding this comment.
Well if it goes away anyway no need to bother with it.
benpicco
approved these changes
Dec 6, 2022
jia200x
force-pushed
the
pr/at86rf2xx/isolate_netdev
branch
from
a4ca5eb to
1d60301
Compare
aabadie
added
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR isolates the netdev logic, in order to facilitate the replacement with the Radio HAL interface.
There's still more cleanup to be done, but I think this is the bare minimum to write the Radio HAL port. We can later continue with optimizations.
Testing procedure
AT86RF2xx devices should still work as expected.
Issues/PRs references
#18967