tests/periph_timer: also test for spurious IRQs #18963
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Dec 8, 2022
Merged
tests/periph_timer: also test for spurious IRQs #18963maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
maribu
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
maribu
added
Type: enhancement
github-actions
bot
added
Area: cpu
maribu
force-pushed
the
tests/periph_timer
branch
from
4787cc2 to
e1d2d1b
Compare
github-actions
bot
added
the
Platform: ESP
Contributor
|
(IMO the periph fixes should not in a |
This was referenced Nov 24, 2022
Member
Author
|
Agreed. It does make testing easier though, if the CI runs the tests along with the fixes. When this is rebased on |
maribu
added
CI: ready for build
This was referenced Nov 25, 2022
To synchronize communication via shared memory between ISR context and thread context it is a common misconception that `volatile` is sufficient. This is however is not the cause and the cause of many subtle data race bugs. This fixes the issue.
Previously the test only checked if IRQs fired when expected. This extends the test to also check that IRQs do not fire when not expected.
maribu
force-pushed
the
tests/periph_timer
branch
from
26558c8 to
496abf0
Compare
github-actions
bot
removed
Area: cpu
This was referenced Nov 25, 2022
Details✅ frdm-k22f
✅ nucleo-f091rc
✅ nucleo-f303re
✅ nucleo-f767zi
✅ nucleo-l152re
✅ arduino-mega2560
✅ nucleo-l432kc
✅ saml10-xpro
✅ saml11-xpro
✅ samr21-xpro
✅ nrf52dk
✅ remote-revb
✅ nucleo-l073rz
✅ slstk3401a
✅ nucleo-f411re
✅ nucleo-f103rb
✅ frdm-kw41z
✅ esp8266-esp-12x
✅ esp32-wroom-32
✅ z1
✅ arduino-due
|
This was referenced Nov 26, 2022
benpicco
approved these changes
Dec 7, 2022
maribu
added
CI: ready for build
maribu
added
CI: ready for build
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Previously the test only checked if IRQs fired when expected. This extends the test to also check that IRQs do not fire when not expected.
In addition, some long overdue style / misuse of
volatilefixes are added as separate commit.Testing procedure
The test app should pass on correct timer drivers (e.g.
samr21-xpro), and fail on broken ones (e.g.nucleo-f767zi).Issues/PRs references
None