Skip to content

treewide: replace RIOT_FILE_RELATIVE with __FILE__#18936

Merged
miri64 merged 6 commits intoRIOT-OS:masterfrom
benpicco:RIOT_FILE_RELATIVE-purge
Nov 19, 2022
Merged

treewide: replace RIOT_FILE_RELATIVE with __FILE__#18936
miri64 merged 6 commits intoRIOT-OS:masterfrom
benpicco:RIOT_FILE_RELATIVE-purge

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Nov 19, 2022 •
edited
Loading

Contribution description

With a recent compiler (GCC ≥ 8) we can define __FILE__ to be relative to the RIOT base directory, so there is no more need for the custom (and fragile) RIOT_FILE_RELATIVE macro.

Testing procedure

Output should stay the same.

Issues/PRs references

#18913 (comment)

@benpicco benpicco added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Nov 19, 2022
@github-actions github-actions bot added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: native Platform: This PR/issue effects the native platform labels Nov 19, 2022
@benpicco benpicco changed the title replace RIOT_FILE_RELATIVE with __FILE__ treewide: replace RIOT_FILE_RELATIVE with __FILE__ Nov 19, 2022
@benpicco benpicco requested a review from maribu November 19, 2022 00:51
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 19, 2022
@maribu
Copy link
Copy Markdown
Member

maribu commented Nov 19, 2022

RIOT_FILE_RELATIVE is IMO internal and doesn't need deprecation. Anyone disagreeing?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 19, 2022

RIOT_FILE_RELATIVE is IMO internal and doesn't need deprecation. Anyone disagreeing?

It is not even documented, so tend to agree.

@riot-ci
Copy link
Copy Markdown

riot-ci commented Nov 19, 2022

Murdock results

✔️ PASSED

dd5c876 cpu/native: replace RIOT_FILE_RELATIVE with FILE

Success Failures Total Runtime
117848 0 117848 02h:34m:01s

Artifacts

@miri64 miri64 merged commit 2a0dad0 into RIOT-OS:master Nov 19, 2022
@benpicco benpicco deleted the RIOT_FILE_RELATIVE-purge branch November 19, 2022 18:58
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
@mguetschow mguetschow mentioned this pull request Feb 25, 2025
Merged
@mguetschow mguetschow mentioned this pull request Mar 25, 2025
Closed
@mguetschow mguetschow mentioned this pull request Mar 25, 2025
Merged
@mguetschow mguetschow mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@cgundogan cgundogan Awaiting requested review from cgundogan

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees

No one assigned

Labels

Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: native Platform: This PR/issue effects the native platform Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2023.01

Development

Successfully merging this pull request may close these issues.

5 participants

@benpicco @maribu @miri64 @riot-ci @kaspar030