how about we put them in one file per macro, named e.g., macros/NO_RETURN.h?

Murdock results

✔️ PASSED

045bd7a core/lib: split kernel defines by its concerns

Artifacts

• Documentation preview

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

how about we put them in one file per macro, named e.g., macros/NO_RETURN.h?

thought about that - but then i saw we can keep the NORETURN from conflicting with similar macros defined in pkgs if we just split by general concern.

thought about that - but then i saw we can keep the NORETURN from conflicting with similar macros defined in pkgs if we just split by general concern.

yes, but, if they're all in one file, I know which file to include. If they are split into files with the same name, I know which to include.

But, if they're put into files according to "general concern", I have to grep a lot to find the right concern.
If I see #include "compiler_hints.h", I don't know why that was included.
And, the "general concern" might be debatable - is IS_CT_CONSTANT(x) a "compiler hint"?

I think I'd like to trade the searching with longer include lists.

Any other opinions?

I think I found a good split but also like get comments / opinions. I think there should be a split (maybe the lines are not yet optimal), i would also like to keep the "kernel_defines.h" like a collection header. And not force a transition to the split includes. But there are cases where you should not include "kernel_defines.h" but a subset is OK.

From my POV #include "kernel_defines.h" is should be avoided in public headers e.g.: in sys/include #include "modules.h"could be used there.

IS_CT_CONSTANT(expr) may not be a hint to the compiler but from it :)

ARRAY_SIZE() might not be well placed in container.h

I searched github wher a define of the name might be: it can be found in util.h, libs.h and obviously most often it is uses to torture gcc.

https://github.com/search?q=%22define+array_size%22&type=Code