drivers/slipdev: fix off-by-one error in _recv()#18826
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Nov 1, 2022
Merged
Conversation
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 269b3c9 drivers/slipdev: fix off-by-one error in _recv()
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
benpicco
added
the
Type: bug
Member
Member
More like, the only person who seems to care, does not have time to review such large changes ^^". |
maribu
approved these changes
Nov 1, 2022
maribu
added
the
Process: needs backport
Member
|
We can still have the PR with the chunked ring buffer merged to |
This was referenced Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This fixes the off-by-one error in SLIP the same way as it was fixed in ethos.
Previously I tried to make SLIP use the chunked ringbuffer to handle this with common code or clean up the driver while fixing the bug, but neither reached consensus.
So this minimal solution should fix the bug while not touching the driver otherwise.
Testing procedure
Issues/PRs references
alternative to #18229, #18066
same as #18823