drivers/ethos: Fix off-by-one bug#18823
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Oct 31, 2022
Merged
Conversation
maribu
added
Type: bug
Member
|
Thx! The fix looks good to me. But I am currently afk to test this. I will do so as soon as possible. But maybe @benpicco is quicker to give this a review. |
maribu
changed the title
Member
|
Oh, could you change the commit title to match the template |
Murdock results✔️ PASSED b1dff29 drivers/ethos: Fix off-by-one in ETHOS driver ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
This was referenced Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ethernet over serial driver
_recvfunction checks the buffer size after writing the data.To fix this I moved the bounds check before the function writing to the buffer.