Murdock results

✔️ PASSED

dc8fe69 cpu/efm32: satisfy vera++

Artifacts

• Documentation preview

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

Finally static tests are fine. I'd say this is ready to be reviewed.

@gschorcht I renamed the power modes and prefixed EFM32 like the stm32 family does.

I will test it later today with my EFM32GG12B board (sltb009a). I have have it not at hand.

I'll test with my board, as well ;-) But Murdock will take until tomorrow, anyways ...

I had include periph/pm.h in cpu/efm32/periph/gpio.c to get it compiled for sltb009a board.

diff --git a/cpu/efm32/periph/gpio.c b/cpu/efm32/periph/gpio.c
index bc74bf6fa0..f7c285ee43 100644
--- a/cpu/efm32/periph/gpio.c
+++ b/cpu/efm32/periph/gpio.c
@@ -24,6 +24,7 @@
 #include "cpu.h"
 
 #include "periph/gpio.h"
+#include "periph/pm.h"
 
 #include "em_gpio.h"

With this change I could compile it. tests/periph_gpio seems to work on my sltb009a board with PM_BLOCKER_INITIAL { 0, 0, 0 } and GPIO_INT_PM_BLOCKER=0.

I had include periph/pm.h in cpu/efm32/periph/gpio.c to get it compiled for sltb009a board.

diff --git a/cpu/efm32/periph/gpio.c b/cpu/efm32/periph/gpio.c
index bc74bf6fa0..f7c285ee43 100644
--- a/cpu/efm32/periph/gpio.c
+++ b/cpu/efm32/periph/gpio.c
@@ -24,6 +24,7 @@
 #include "cpu.h"
 
 #include "periph/gpio.h"
+#include "periph/pm.h"
 
 #include "em_gpio.h"

With this change I could compile it. tests/periph_gpio seems to work on my sltb009a board with PM_BLOCKER_INITIAL { 0, 0, 0 } and GPIO_INT_PM_BLOCKER=0.

I inlcuded pm_layered.h (it defines pm_block() and pm_unblock()) and board.h, which can be used to define GPIO_INT_PM_BLOCKER.

I had success, as well: The (not upstream, yet) board xg23b-pk6068a blocks the right PM mode and can be woken up with an GPIO IRQ:

> pm show
2022-10-19 00:21:32,733 # pm show
2022-10-19 00:21:32,734 # mode 0 blockers: 0 
2022-10-19 00:21:32,734 # mode 1 blockers: 1 
2022-10-19 00:21:32,736 # mode 2 blockers: 0 
2022-10-19 00:21:32,741 # Lowest allowed mode: 2
> init_int 1 1 0 0
2022-10-19 00:21:37,203 # init_int 1 1 0 0
2022-10-19 00:21:37,206 # GPIO_PIN(1, 1) successfully initialized as ext int
2022-10-19 00:21:43,636 # INT: external interrupt from pin 1
(... pressing the button logs into the console)
> pm unblock 1
2022-10-19 00:21:52,745 # pm unblock 1
2022-10-19 00:21:52,746 # Unblocking power mode 1.
> help
(... console is stalled ... the UART is disabled)
2022-10-19 00:21:58,405 # INT: external interrupt from pin 1
(... pressing the button still logs into the console)

Murdock is also happy :) Thank you for reviewing!