cpu/sam0_common: ADC keep muxpos as legacy define#18688
Merged
dylad merged 1 commit intoRIOT-OS:masterfrom Oct 5, 2022
Merged
Conversation
github-actions
bot
added
Area: cpu
benpicco
added
the
Impact: minor
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 5843ff4 cpu/sam0_common: ADC keep muxpos as legacy define
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
maribu
approved these changes
Oct 5, 2022
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
Ahh, yes. The transition to a newer version of C allows anonymous unions as struct members :)
Member
|
Don't forget to remove this in a few months :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
.muxposmember was renamed to.inputctrlto make clearer that it can contain more than just the positive mux.This however makes working with external boards much more painful, especially when bisecting something.
The semantics of the field did not change, so also provide the old name in a
unionto make the transition less painful.Testing procedure
Issues/PRs references
follow-up to #18658