Merged
Conversation
chrysn
added
Impact: minor
chrysn
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Area: drivers
The change in 399e25c was did not have the intended effect: As the local crates still all defined 0.7 as the riot-wrappers version, that dependency was actually down- rather than upgraded, and thus did not effect the stabilizations.
chrysn
force-pushed
the
rust-update-20221001-fix
branch
from
81e59cc to
69cb6b1
Compare
Murdock results✔️ PASSED 69cb6b1 rust: Update dependencies
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
maribu
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in 399e25c (#18678) was did not have the intended effect: As the local crates still all defined 0.7 as the riot-wrappers version, that dependency was actually down- rather than upgraded, and thus did not effect the stabilizations.
This went unnoticed for two reasons:
I only noticed it now when later changes on the riot-wrappers side, being tested there, broke in ways that should long have been fixed.
Asking @maribu for a review as he also reviewed #18678, and (even though there is no CI-observable breakage) this does fix a regression introduced there.