cpu/sam0_common: adc: drop pin from adc_conf_chan_t#18658
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Sep 28, 2022
Merged
cpu/sam0_common: adc: drop pin from adc_conf_chan_t#18658benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
dylad,
jia200x,
keestux and
leandrolanzieri
as code owners
github-actions
bot
added
Area: boards
dylad
requested changes
Sep 27, 2022
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
Spotted a mistake.
Feels free to squash right away
benpicco
force-pushed
the
cpu/sam0_adc-rework
branch
from
fec7c79 to
2c9a385
Compare
dylad
added
the
CI: ready for build
benpicco
added
the
Process: API change
Contributor
Author
|
Thank you for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
.pinmember is no longer used and the.muxposmember is much more than just MUXPOS now - so drop the.pinand while we change the API anyway, also rename.muxpos.Testing procedure
Issues/PRs references
follow-up to #18146