Skip to content

shell: fix gnrc_netif_lorawan dependency#18648

Closed
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64:shell/fix/netif_lorawan_dependency
Closed

shell: fix gnrc_netif_lorawan dependency#18648
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64:shell/fix/netif_lorawan_dependency

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 26, 2022

Contribution description

Restores LoRa functionality for the ifconfig command (see #18355 (comment) ff).

Testing procedure

Run and compile examples/gnrc_lorawan for BOARD=b-l072z-lrwan1. With this change LoRa specific output will be provided with ifconfig

> ifconfig
ifconfig
Iface  3  HWaddr: 00:00:00:00  Frequency: 868299987Hz  RSSI: -157  BW: 125kHz  SF: 7  CR: 4/5  Link: down 
           TX-Power: 14dBm  State: SLEEP  Demod margin.: 0  Num gateways.: 0 
          OTAA  
          L2-PDU:255  
          
> version
version
2022.10-devel-882-g43fab-shell/fix/netif_lorawan_dependency

Without it, it is missing

> ifconfig
ifconfig
Iface  3  HWaddr: 00:00:00:00  Frequency: 868299987Hz  RSSI: -157  Link: down 
           TX-Power: 14dBm  State: SLEEP 
          OTAA  
          L2-PDU:255  
          
> version
version
2022.10-devel-881-g6988db

Issues/PRs references

Follow-up to #18355

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 26, 2022
@github-actions github-actions bot added the Area: sys Area: System label Sep 26, 2022
@miri64 miri64 mentioned this pull request Sep 26, 2022
Merged
@benpicco benpicco requested a review from maribu September 26, 2022 10:08
@miri64 miri64 force-pushed the shell/fix/netif_lorawan_dependency branch from 43fab80 to b2cef7a Compare September 26, 2022 10:09
@maribu maribu mentioned this pull request Sep 26, 2022
Merged
@maribu
Copy link
Copy Markdown
Member

maribu commented Sep 26, 2022

IMO it is better to have the LoRaWAN integration of the shell_cmd_gnrc_netif shell command as a submodule of it, e.g. shell_cmd_gnrc_netif_lorawan. See #18649 for what I would propose instead.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 26, 2022

Indeed. Closing in favor for #18649!

@miri64 miri64 closed this Sep 26, 2022
@miri64 miri64 deleted the shell/fix/netif_lorawan_dependency branch September 26, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu Awaiting requested review from maribu

Assignees

No one assigned

Labels

Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @maribu