treewide: fix conditionals on deprecated module#18616
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Sep 21, 2022
Merged
Conversation
As a leftovers from RIOT-OS#18355 are still present that check for `MODULE_SHELL_COMMANDS` rather than `MODULE_SHELL_CMDS`. This updates the conditionals as needed.
maribu
added
Type: bug
maribu
requested review from
MrKevinWeiss,
jia200x,
leandrolanzieri and
miri64
as code owners
github-actions
bot
added
Area: BLE
miri64
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
As a leftovers from #18355 are still present that check for
MODULE_SHELL_COMMANDSrather thanMODULE_SHELL_CMDS. This updates the conditionals as needed.Testing procedure
ifconfigshell command intests/lwipshould show an IPv6 address again. (I can confirm that is does so.)tests/nimble_netif_extshould be fixed. (I can confirm that the text size grows with this, but I wasn't able to detect an obvious issue with theifconfigcmd there.)Issues/PRs references
Regression introduced in #18355