Skip to content

drivers/mrf24j40: add support for IEEE 802.15.4 Radio HAL#18472

Merged
bors[bot] merged 14 commits intoRIOT-OS:masterfrom
jia200x:pr/mrf24j40_radio_hal
Jan 19, 2023
Merged

drivers/mrf24j40: add support for IEEE 802.15.4 Radio HAL#18472
bors[bot] merged 14 commits intoRIOT-OS:masterfrom
jia200x:pr/mrf24j40_radio_hal

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Aug 18, 2022 •
edited
Loading

Contribution description

Since #18383 already got merged, it's time to add the IEEE 802.15.4 Radio HAL port for MRF24J40 radios.
This one was supported by LWIP, which requires #18465 to be merged first.

This PR also adds the Arduino Pin config for nucleo64 boards and fixes some tiny issues in the CCA functions of the Radio HAL and tests.

Strictly speaking this PR changes the API of mrf24j40_init, but IMO adding a deprecation at this level does not make sense.
It also removes the old netdev implementation.

Testing procedure

Connect a MRF24J40 to the Arduino Pins, try tests/ieee802154_* tests, the LWIP tests and examples/gnrc_networking. Everything should work as before.

Issues/PRs references

Depends on #18465

@jia200x jia200x changed the title Pr/mrf24j40 radio hal drivers/mrf24j40: add support for IEEE 802.15.4 Radio HAL Aug 18, 2022
@github-actions github-actions bot added Area: boards Area: Board ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Aug 18, 2022
@jia200x jia200x added the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 18, 2022
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Aug 18, 2022

Maybe interesting for @Carton32?

@Carton32
Copy link
Copy Markdown

Carton32 commented Aug 19, 2022

Maybe interesting for @Carton32?

Thanks! I will have a look.

@jia200x jia200x mentioned this pull request Aug 19, 2022
Open
8 tasks
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Aug 22, 2022 •
edited
Loading

I rebased this one on top of #18496 and the PRR of the SubMAC seems to boost even more:

 ping fe80::58a0:384a:c482:9848 -s 1024 -i 250 -c 500

2022-08-22 15:23:00,346 # --- fe80::58a0:384a:c482:9848 PING statistics ---
2022-08-22 15:23:00,351 # 500 packets transmitted, 500 packets received, 0% packet loss
2022-08-22 15:23:00,356 # round-trip min/avg/max = 138.670/147.799/182.829 ms


2022-08-22 17:50:20,825 # 
2022-08-22 17:50:20,829 # --- fe80::58a0:384a:c482:9848 PING statistics ---
2022-08-22 17:50:20,835 # 10000 packets transmitted, 9997 packets received, 0% packet loss
2022-08-22 17:50:20,839 # round-trip min/avg/max = 135.234/148.009/183.048 ms
2022-08-22 17:57:58,940 # Exiting Pyterm

@jia200x jia200x force-pushed the pr/mrf24j40_radio_hal branch from c7f099d to 0fe14d2 Compare August 22, 2022 14:32
@jia200x jia200x mentioned this pull request Aug 22, 2022
Merged
@jia200x jia200x force-pushed the pr/mrf24j40_radio_hal branch from 75a4253 to d65a4c4 Compare August 26, 2022 10:26
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Aug 26, 2022

rebased to latest master

@jia200x jia200x force-pushed the pr/mrf24j40_radio_hal branch from d65a4c4 to 63bb3b0 Compare August 26, 2022 10:27
@benpicco benpicco removed the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 31, 2022
benpicco
benpicco reviewed Jan 19, 2023
View reviewed changes
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 19, 2023

Please squash

jia200x added 13 commits January 19, 2023 15:31
@jia200x jia200x force-pushed the pr/mrf24j40_radio_hal branch from 3db5f2b to fc0e59c Compare January 19, 2023 14:35
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jan 19, 2023

it passes now with the whitelist

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 19, 2023

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jan 19, 2023

👎 Rejected by too few approved reviews

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 19, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 19, 2023
@bors @jia200x
Merge #18472
88ee0c4 
18472: drivers/mrf24j40: add support for IEEE 802.15.4 Radio HAL r=benpicco a=jia200x



Co-authored-by: Jose Alamos <[email protected]>
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 19, 2023

bors cancel

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jan 19, 2023

Canceled.

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jan 19, 2023

Build succeeded:

@bors bors bot merged commit d11a358 into RIOT-OS:master Jan 19, 2023
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jan 20, 2023

thanks for the review!

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Jan 24, 2023

I wonder why bors merged something that failed in master...

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Jan 24, 2023

Oh it passed: https://ci.riot-os.org/results/9b929e70b69b44fe9052b34a0eed0b28/output/builds/tests/ieee802154_hal/nucleo-wl55jc:gnu.txt

@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss left review comments

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@cgundogan cgundogan Awaiting requested review from cgundogan

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms

Projects

None yet

Milestone

Release 2023.04

Development

Successfully merging this pull request may close these issues.

8 participants

@jia200x @PeterKietzmann @Carton32 @benpicco @riot-ci @MrKevinWeiss @kaspar030 @miri64