makefiles: quiet messages on CI by MrKevinWeiss · Pull Request #18470 · RIOT-OS/RIOT

MrKevinWeiss · 2022-08-18T11:58:46Z

Contribution description

After introducing #18423 there are occasional messages that still happen.
These messages cause a diff output when testing with TEST_KCONFIG=1.
This then causes a failure when comparing make/kconfig modules and packages.

Testing procedure

rm -f dist/tools/kconfiglib/menuconfig.py && /bin/bash -c "source .murdock; compile tests/shell native:gnu"

Issues/PRs references

Introduced in #18423
Discovered by #18466

MrKevinWeiss · 2022-08-18T12:01:10Z

ping @maribu @benpicco @leandrolanzieri

MrKevinWeiss · 2022-08-18T12:05:49Z

Hmmm will that work or will it still show

git-cache: cloning from cache. tag=commit061e71f7d78cb057762d88de088055361863deff-1639

On the output failure we see it:

-- running on worker riotbuild-4 thread 2, build number 30999.
make: Entering directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
make: Leaving directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
make: Entering directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
Building application "tests_test_tools" for "dwm1001" with MCU "nrf52".

sha1sum /tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools/tests/01-run.py /tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/build/tests_test_tools.bin > /tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/build/test-input-hash.sha1
   text	   data	    bss	    dec	    hex	filename
  10088	    128	   2632	  12848	   3230	/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/build/tests_test_tools.elf
make: Leaving directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
0a1,3
> [INFO] Kconfiglib not found - getting it
> git-cache: cloning from cache. tag=commit061e71f7d78cb057762d88de088055361863deff-1639
> [INFO] Kconfiglib downloaded
{"build/": 1864}

But locally I don't. Let me keep testing.

MrKevinWeiss · 2022-08-18T12:07:56Z

Nope still doesn't work... let me keep trying...

MrKevinWeiss · 2022-08-18T12:11:53Z

OK better test and better results. Now I am happy.

MrKevinWeiss · 2022-08-18T17:45:55Z

Heh, well that super didn't work... I will have to revisit it when I have time.

MrKevinWeiss · 2022-08-22T08:29:22Z

Strange error now:

Details

-- running on worker mobi3 thread 17, build number 131395.
make: Entering directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
# Reset package to checkout state.
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg/c25519
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg-build/libcose
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg-build/littlefs2
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg-build/nanocbor
make: Leaving directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
make: Entering directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
make: *** No rule to make target '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update/bin/native/suit_update/fw.1661156187.bin', needed by 'link'.  Stop.
make: *** Waiting for unfinished jobs....
Building application "suit_update" for "native" with MCU "native".

make: Leaving directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
cat: /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/test-input-hash.sha1: No such file or directory

rerunning

MrKevinWeiss · 2022-08-22T09:04:01Z

Maybe a mobi3 specific problem? Running locally seems to work.

MrKevinWeiss · 2022-08-22T09:16:15Z

As my make knowledge is not so great maybe it would be worth looking at the code. I simply want to quiet the output if RIOT_CI_BUILD is 1, but still clone and build the kconfig library if it is missing.

If this passes it is probably good to merge in before starting other builds as this would prevent the false positives. My only concern is that maybe all the conditions are not hit in this run (ie, all the libs are build but if we clean out a worker it will throw different errors).

benpicco · 2022-08-22T09:19:57Z

makefiles/tools/kconfiglib.inc.mk

 GENCONFIG := $(RIOTTOOLS)/kconfiglib/genconfig.py

+ifeq ($(RIOT_CI_BUILD),1)
+  QUIETMESSAGES=":"


What is : supposed to do?

Apparently the make way to optionally quiet the echos...

Very open to suggestions.

huh TIL, I only knew about @ to silence echoing the command

MrKevinWeiss · 2022-08-22T09:27:04Z

We could also hit it from diff side. The whole issues is that there is extra output when using info-modules info-packages, I just do a simple diff. Maybe we can either strip extras or have different targets that are a bit more robust or so.

This is getting to one of those issues where in theory it is simple but reality becomes more and more complex with a whole bunch of small corner cases.

makefiles/tools/kconfiglib.inc.mk

After introducing RIOT-OS#18423 there are occasional messages that still happen. These messages cause a diff output when testing with TEST_KCONFIG=1. This then causes a failure when comparing make/kconfig modules and packages.

MrKevinWeiss · 2022-08-22T09:37:06Z

Pushed the fixes and squashed

MrKevinWeiss · 2022-08-22T11:33:53Z

Nice, thanks @benpicco. Let's hope that is the last of it.

MrKevinWeiss added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Aug 18, 2022

github-actions bot added Area: build system Area: Build system Area: tools Area: Supplementary tools labels Aug 18, 2022

MrKevinWeiss added Area: CI Area: Continuous Integration of RIOT components and removed Area: build system Area: Build system Area: tools Area: Supplementary tools labels Aug 18, 2022

MrKevinWeiss changed the title ~~makefiles: quite messages on CI~~ makefiles: quiet messages on CI Aug 18, 2022

MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from 64a256b to 385a115 Compare August 18, 2022 12:00

github-actions bot added Area: build system Area: Build system Area: tools Area: Supplementary tools and removed Area: CI Area: Continuous Integration of RIOT components labels Aug 18, 2022

MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 18, 2022

benpicco approved these changes Aug 18, 2022

View reviewed changes

MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from 385a115 to c7f6adf Compare August 18, 2022 12:11

leandrolanzieri enabled auto-merge August 18, 2022 13:25

MrKevinWeiss disabled auto-merge August 18, 2022 17:45

This was referenced Aug 19, 2022

pkg/{littlefs,littlefs2}: fix unaligned memory accesses #18473

Merged

.murdock: disable Kconfig hash comparison #18399

Closed

MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from c7f6adf to 6e9968d Compare August 22, 2022 08:00

benpicco reviewed Aug 22, 2022

View reviewed changes

makefiles/tools/kconfiglib.inc.mk Outdated Show resolved Hide resolved

benpicco reviewed Aug 22, 2022

View reviewed changes

makefiles/tools/kconfiglib.inc.mk Outdated Show resolved Hide resolved

makefiles: quiet messages on CI

0489630

After introducing RIOT-OS#18423 there are occasional messages that still happen. These messages cause a diff output when testing with TEST_KCONFIG=1. This then causes a failure when comparing make/kconfig modules and packages.

MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from 6e9968d to 0489630 Compare August 22, 2022 09:36

benpicco enabled auto-merge August 22, 2022 11:26

benpicco merged commit 6c6ebce into RIOT-OS:master Aug 22, 2022

MrKevinWeiss deleted the pr/fixmurdockloudness branch August 22, 2022 11:33

maribu added this to the Release 2022.10 milestone Oct 14, 2022

Conversation

MrKevinWeiss commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

MrKevinWeiss commented Aug 18, 2022

Uh oh!

MrKevinWeiss commented Aug 18, 2022

Uh oh!

MrKevinWeiss commented Aug 18, 2022

Uh oh!

MrKevinWeiss commented Aug 18, 2022

Uh oh!

MrKevinWeiss commented Aug 18, 2022

Uh oh!

MrKevinWeiss commented Aug 22, 2022

Uh oh!

MrKevinWeiss commented Aug 22, 2022

Uh oh!

MrKevinWeiss commented Aug 22, 2022

Uh oh!

benpicco Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

MrKevinWeiss Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

MrKevinWeiss Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

benpicco Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

MrKevinWeiss commented Aug 22, 2022

Uh oh!

Uh oh!

Uh oh!

MrKevinWeiss commented Aug 22, 2022

Uh oh!

MrKevinWeiss commented Aug 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MrKevinWeiss commented Aug 18, 2022 •

edited

Loading