Skip to content

cpu/{sam0_common, stm32}: select netdev_legacy_api in KConfig#18466

Merged
MrKevinWeiss merged 3 commits intoRIOT-OS:masterfrom
benpicco:netdev_legacy_api-KConfig
Aug 18, 2022
Merged

cpu/{sam0_common, stm32}: select netdev_legacy_api in KConfig#18466
MrKevinWeiss merged 3 commits intoRIOT-OS:masterfrom
benpicco:netdev_legacy_api-KConfig

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Aug 17, 2022

Contribution description

This fixes the discrepancy between the USEMODULE based dependency resolution and the KConfig based dependency resolution.

Testing procedure

CI should build again

Issues/PRs references

follow-up to #18426

@benpicco benpicco requested a review from maribu August 17, 2022 21:39
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Aug 17, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer and removed Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Aug 17, 2022
MrKevinWeiss
MrKevinWeiss approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested with

for test in tests/driver_sam0_eth tests/driver_stm32_eth/; do for board in same54-xpro nucleo-f767zi nucleo-f429zi nucleo-f207zg; do echo $board && /bin/bash -c "source .murdock; JOBS=4 compile ${test} ${board}:gnu"; done; done;

and it seems to fix the problem.

@MrKevinWeiss MrKevinWeiss enabled auto-merge August 17, 2022 21:53
@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Aug 17, 2022

Now that #18423 we can let automerge to the work and don't need to abuse the skip compile test label 😉

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Aug 17, 2022

Also, thank you for such a fast fix!

@benpicco
pkg/lorabasics: fix unused parameters warning
d8735c0 
CI now fails because of this :(
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Aug 17, 2022
@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Aug 17, 2022

For some reason CI now fails when compiling tests/driver_sx1280 because of unused parameters…
I added a commit to fix that as well.

@github-actions github-actions bot added the Area: drivers Area: Device drivers label Aug 18, 2022
@maribu
Copy link
Copy Markdown
Member

maribu commented Aug 18, 2022

tests/driver_sx1280 also failed due to netdev_legacy_api not being selected in KConfig. I added a commit that should fix this.

This was referenced Aug 18, 2022
Merged
Merged
@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Aug 18, 2022

Thanks @maribu

@MrKevinWeiss MrKevinWeiss added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 18, 2022
@MrKevinWeiss MrKevinWeiss merged commit f820f94 into RIOT-OS:master Aug 18, 2022
@benpicco benpicco deleted the netdev_legacy_api-KConfig branch August 18, 2022 11:58
@MrKevinWeiss MrKevinWeiss mentioned this pull request Aug 18, 2022
Merged
@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Aug 18, 2022

That is one down. Thanks again reacting so fast!

@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@maribu maribu Awaiting requested review from maribu

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2022.10

Development

Successfully merging this pull request may close these issues.

3 participants

@benpicco @MrKevinWeiss @maribu