cpu/stm32/periph_eth: optimize IRQ handler#18417
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Aug 9, 2022
Merged
Conversation
github-actions
bot
added
Area: cpu
maribu
added
Type: enhancement
3 tasks
maribu
force-pushed
the
cpu/stm32/periph/stm32_eth/optimization
branch
from
a5c35af to
9c0ecd8
Compare
github-actions
bot
added
Platform: ARM
fabian18
approved these changes
Aug 8, 2022
Contributor
fabian18
left a comment
fabian18
left a comment
There was a problem hiding this comment.
I tested with ncput.
ncput /nvm0/send/ta/cert.der coap://[fe80::3478:9157:9fd5:81c3]/cert.der
2022-08-08 23:55:47,768 # ncput /nvm0/send/ta/cert.der coap://[fe80::3478:9157:9fd5:81c3]/cert.der
2022-08-08 23:55:50,386 # Saved to coap://[fe80::3478:9157:9fd5:81c3]/cert.der
> ncput /nvm0/send/ta/cert.der coap://[fe80::3478:9157:9fd5:81c3]/cert.der
2022-08-08 23:56:01,131 # ncput /nvm0/send/ta/cert.der coap://[fe80::3478:9157:9fd5:81c3]/cert.der
2022-08-08 23:56:01,219 # Saved to coap://[fe80::3478:9157:9fd5:81c3]/cert.der
> ncput /nvm0/send/ta/cert.der coap://[fe80::3478:9157:9fd5:81c3]/cert.der
2022-08-08 23:56:07,975 # ncput /nvm0/send/ta/cert.der coap://[fe80::3478:9157:9fd5:81c3]/cert.der
2022-08-08 23:56:08,063 # Saved to coap://[fe80::3478:9157:9fd5:81c3]/cert.der
It is still working well and the changes make sense.
We can just clear both TX and RX IRQ flags in any case, as clearing a non-set flag is just a nop.
maribu
force-pushed
the
cpu/stm32/periph/stm32_eth/optimization
branch
from
9c0ecd8 to
bf67a9c
Compare
maribu
added
CI: ready for build
chrysn
added
CI: ready for build
5 tasks
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
We can just clear both TX and RX IRQ flags in any case, as clearing a non-set flag is just a nop.
Testing procedure
Network operation should still work as usual.
Issues/PRs references