Skip to content

gnrc_ipv6_nib: use correct DHCPv6 client module name [backport 2022.07]#18413

Merged
miri64 merged 1 commit intoRIOT-OS:2022.07-branchfrom
benpicco:backport/2022.07/CONFIG_GNRC_IPV6_NIB_ADV_ROUTER-fix
Aug 8, 2022
Merged

gnrc_ipv6_nib: use correct DHCPv6 client module name [backport 2022.07]#18413
miri64 merged 1 commit intoRIOT-OS:2022.07-branchfrom
benpicco:backport/2022.07/CONFIG_GNRC_IPV6_NIB_ADV_ROUTER-fix

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Aug 7, 2022 •
edited
Loading

Backport of #18402

Contribution description

The patch that introduced this was backported, so we need to backport the fix as well.

MODULE_GNRC_DHCPV6_CLIENT_IA_PD does not exist, the correct module name is MODULE_DHCPV6_CLIENT_IA_PD.

Testing procedure

I noticed that when running examples/gnrc_border_router with UPLINK=wifi I would not get a global address on the upstream interface because RTR_ADV was enabled on it.

With the config properly set, RTR_ADV is only enabled on the downstream interface after a delegated prefix was received.

Issues/PRs references

follow-up to #18360

@benpicco
gnrc_ipv6_nib: use correct DHCPv6 client module name
56e713a 
`MODULE_GNRC_DHCPV6_CLIENT_IA_PD` does not exist, the correct module name
is `MODULE_DHCPV6_CLIENT_IA_PD`.

(cherry picked from commit f6cef27)
@benpicco benpicco added Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Aug 7, 2022
@benpicco benpicco requested a review from chrysn August 7, 2022 19:34
@benpicco benpicco added this to the Release 2022.07 milestone Aug 7, 2022
@benpicco benpicco requested a review from miri64 August 8, 2022 12:48
@chrysn chrysn mentioned this pull request Aug 8, 2022
Merged
@miri64 miri64 enabled auto-merge August 8, 2022 15:52
@miri64 miri64 merged commit 4908149 into RIOT-OS:2022.07-branch Aug 8, 2022
@benpicco benpicco deleted the backport/2022.07/CONFIG_GNRC_IPV6_NIB_ADV_ROUTER-fix branch August 8, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@chrysn chrysn Awaiting requested review from chrysn

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2022.07

Development

Successfully merging this pull request may close these issues.

2 participants

@benpicco @miri64