cpu/esp32: add ESP32-S3 support to makefiles#18410
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Aug 10, 2022
Merged
Conversation
github-actions
bot
added
Area: cpu
gschorcht
added
Type: new feature
gschorcht
force-pushed
the
cpu/esp32/add_esp32s3_makefiles
branch
from
ccb77ea to
b355ef4
Compare
gschorcht
added
CI: ready for build
gschorcht
force-pushed
the
cpu/esp32/add_esp32s3_makefiles
branch
from
b355ef4 to
bfbaee5
Compare
chrysn
added
CI: ready for build
gschorcht
force-pushed
the
cpu/esp32/add_esp32s3_makefiles
branch
from
bfbaee5 to
2902a9a
Compare
benpicco
approved these changes
Aug 9, 2022
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Wouldn't have minded keeping this with the rest, so it can be compile tested.
But code looks good.
gschorcht
added
CI: ready for build
Contributor
Author
|
Unfortunately, again an unrelated hash mismatch error, so I restarted the CI build with the label 'CI: skip compile test' to avoid unecessary CI load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from #18185 and adds the support of ESP32-S3 to the makefiles.
Testing procedure
Green CI
Issues/PRs references
Split-off from #18185