gnrc_ipv6_nib: use correct DHCPv6 client module name#18402
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Aug 6, 2022
Merged
gnrc_ipv6_nib: use correct DHCPv6 client module name#18402benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: Kconfig
benpicco
added
Type: bug
`MODULE_GNRC_DHCPV6_CLIENT_IA_PD` does not exist, the correct module name is `MODULE_DHCPV6_CLIENT_IA_PD`.
benpicco
force-pushed
the
CONFIG_GNRC_IPV6_NIB_ADV_ROUTER-fix
branch
from
b4dd65f to
f6cef27
Compare
miri64
approved these changes
Aug 5, 2022
Member
|
Exhibit A for why I don't ACK my own changes or trust my own testing 😝 |
benpicco
added
the
Process: needs backport
Contributor
Author
|
Continuous improvement is better than delayed perfection 😉 |
benpicco
added
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
MODULE_GNRC_DHCPV6_CLIENT_IA_PDdoes not exist, the correct module name isMODULE_DHCPV6_CLIENT_IA_PD.Testing procedure
I noticed that when running
examples/gnrc_border_routerwithUPLINK=wifiI would not get a global address on the upstream interface becauseRTR_ADVwas enabled on it.With the config properly set,
RTR_ADVis only enabled on the downstream interface after a delegated prefix was received.Issues/PRs references
follow-up to #18360