Skip to content

drivers/mtd: fix module name for mtd_sdcard in Kconfig#18395

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:drivers/mtd/fix_kconfig
Aug 4, 2022
Merged

drivers/mtd: fix module name for mtd_sdcard in Kconfig#18395
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:drivers/mtd/fix_kconfig

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Aug 3, 2022

Contribution description

This PR fixes the module name in drivers/mtd/Kconfig for module mtd_sdcard.

The used module is called mtd_sdcard. Dependencies in Kconfig has to use same name for the module and should use the name for the feature. Therefore,

  • HAVE_MTD_SD_CARD is changed to HAVE_MTD_SDCARD and
  • MODULE_MTD_SD_CARD is changed to MODULE_MTD_SDCARD.

Testing procedure

Green CI

Issues/PRs references

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Aug 3, 2022
@gschorcht gschorcht requested a review from fjmolinas August 3, 2022 06:03
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 3, 2022
@gschorcht gschorcht mentioned this pull request Aug 3, 2022
Merged
10 tasks
@gschorcht gschorcht force-pushed the drivers/mtd/fix_kconfig branch from 3adcc96 to a0d8882 Compare August 3, 2022 06:27
leandrolanzieri
leandrolanzieri approved these changes Aug 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Aug 3, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 3, 2022
@benpicco benpicco enabled auto-merge August 3, 2022 21:28
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 4, 2022
@benpicco benpicco merged commit fb1f5b3 into RIOT-OS:master Aug 4, 2022
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Aug 4, 2022 •
edited
Loading

I skipped the compilation test the last time after the previous 3 tries failed only due to the unrelated hash mismatch errors.

@gschorcht gschorcht deleted the drivers/mtd/fix_kconfig branch August 8, 2022 07:36
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2022.10

Development

Successfully merging this pull request may close these issues.

4 participants

@gschorcht @leandrolanzieri @benpicco @maribu