Skip to content

tests/ieee802154_*: fix tx_done handler on ACK_TIMEOUT and improve tests#18382

Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom
jia200x:pr/ieee802154_tests_fixes
Jul 28, 2022
Merged

tests/ieee802154_*: fix tx_done handler on ACK_TIMEOUT and improve tests#18382
benpicco merged 3 commits intoRIOT-OS:masterfrom
jia200x:pr/ieee802154_tests_fixes

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Jul 28, 2022

Contribution description

This PR takes over original work by @MichelRottleuthner and does essentially 3 things:

  1. It fixes a missing call to ieee802154_set_rx on TX_DONE if the radio supports ACK_TIMEOUT or FRAME_RETRANS.
  2. It adds support for ACK_REQ flag in tests/ieee802154_hal
  3. It indicates the received packet length in tests/ieee802154_submac

Testing procedure

  1. Make sure tests/ieee802154_hal works as expected and try sending messages with and without ACK_REQ:
txtsnd <ext_addr> <len> ack_req
txtsnd <ext_addr> <len>
  1. Make sure tests/ieee802154_submac works as expected and displays the received packet length.

Issues/PRs references

None so far, but it will be required for the KW2xRF Radio HAL port

Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 28, 2022
@benpicco benpicco merged commit 35d2af3 into RIOT-OS:master Jul 28, 2022
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants