Skip to content

cpu/esp_{common,32,8266}: improve Kconfig submenu structure#18314

Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom
gschorcht:cpu/esp/improve_kconfig_submenu_structure
Jul 18, 2022
Merged

cpu/esp_{common,32,8266}: improve Kconfig submenu structure#18314
benpicco merged 3 commits intoRIOT-OS:masterfrom
gschorcht:cpu/esp/improve_kconfig_submenu_structure

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

Contribution description

This PR improves the Kconfig submenu structure for ESP SoCs.

Without this PR, some ESP SoC specific configurations are shown in top menu and not in the ESP specific submenus:

  • ESP8266
    (Top)
                                                                 RIOT Configuration
        ESP8266 specific configurations  --->
        ESP configurations  --->
    [ ] Simulate ESP with QEMU
    [ ] Use software timer
    [ ] gdbstub interface support
    [*] RIOT Core  --->
    ...
    
  • ESP32
    (Top)
                                                                 RIOT Configuration
        ESP32 specific configurations  --->
    [ ] Use hardware counter
        ESP configurations  --->
    [ ] Simulate ESP with QEMU
    [*] RIOT Core  --->
    ...
    

With this PR, these ESP SoC specific configurations are moved to the appropriate submenus and give a much more structured view of the ESP specific configuration options:

  • ESP8266
    (Top)
                                                                 RIOT Configuration
        ESP8266 specific configurations  --->
        ESP configurations  --->
    [*] RIOT Core  --->
    ...
    
    (Top) → ESP8266 specific configurations
                                                                 RIOT Configuration
        CPU clock frequency (80 MHz)  --->
    [ ] Use software timer as low-level timer peripheral
    [ ] gdbstub interface support
    
    (Top) → ESP configurations
                                                                 RIOT Configuration
    [ ] Add additional information to the log output
    [ ] Add additional startup information to the log output
    [ ] Simulate ESP with QEMU
    
  • ESP32
        ESP32 specific configurations  --->
        ESP configurations  --->
    [*] RIOT Core  --->
    ...
    
    (Top) → ESP32 specific configurations
                                                                 RIOT Configuration
       CPU clock frequency (80 MHz)  --->
    [ ] SPI RAM support
    [*] Enable JTAG debugging interface
    [ ] Use hardware counter as low-level timer peripheral
    
    (Top) → ESP configurations
                                                                 RIOT Configuration
    [ ] Add additional information to the log output
    [ ] Add additional startup information to the log output
    [ ] Simulate ESP with QEMU
    

Testing procedure

  1. Green CI
  2. Using
    TEST_KCONFIG=1 BOARD=esp8266-esp-12x make -C tests/periph_timer menuconfig
    TEST_KCONFIG=1 BOARD=esp32-wrover-kit make -C tests/periph_timer menuconfig
    
    should show the configuration menu structure.

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jul 18, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jul 18, 2022
@gschorcht gschorcht changed the title cpu/esp{common,32,8266}: improve Kconfig submenu structure cpu/esp_{common,32,8266}: improve Kconfig submenu structure Jul 18, 2022
@benpicco benpicco merged commit 897abd0 into RIOT-OS:master Jul 18, 2022
@gschorcht
Copy link
Copy Markdown
Contributor Author

Wow, the fastest review and merge I got for a PR ever. Thanks. So I can change Kconfig in PR #18317 without any conflicts.

@gschorcht gschorcht deleted the cpu/esp/improve_kconfig_submenu_structure branch July 18, 2022 11:28
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants