Skip to content

cpu/esp32: use ESP-IDF timer/interrupt HAL for periph/timer#18282

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/periph_hal_esp32_periph_timer
Jul 15, 2022
Merged

cpu/esp32: use ESP-IDF timer/interrupt HAL for periph/timer#18282
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/periph_hal_esp32_periph_timer

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Jun 28, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841 and provides the changes to use the ESP-IDF timer HAL and ESP-IDF interrupt HAL.

Testing procedure

  1. Compile and test the default implementation using ESP32x SoC peripheral timer groups: 
    USEMODULE='esp_log_startup' BOARD=esp32-wroom-32 make -j8 -C tests/periph_timer flash term
  2. Compile and test the hardware counter implementation: 
    USEMODULE='esp_log_startup esp_hw_counter' BOARD=esp32-wroom-32 make -j8 -C tests/periph_timer flash term

Issues/PRs references

Split-off from PR #17841

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 19:54
@gschorcht gschorcht changed the title cpu/esp32: ESP-IDF timer/interrupt HAL for periph/timer cpu/esp32: use ESP-IDF timer/interrupt HAL for periph/timer Jun 28, 2022
benpicco
benpicco reviewed Jul 13, 2022
View reviewed changes
benpicco
benpicco approved these changes Jul 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash!

@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_periph_timer branch from 0304459 to 3fd7e1a Compare July 15, 2022 04:40
@benpicco benpicco enabled auto-merge July 15, 2022 08:57
@benpicco benpicco merged commit 0c56e28 into RIOT-OS:master Jul 15, 2022
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Jul 15, 2022

@benpicco Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp32/periph_hal_esp32_periph_timer branch July 15, 2022 09:12
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2022.07

Development

Successfully merging this pull request may close these issues.

3 participants

@gschorcht @benpicco @chrysn