cpu/esp32: use ESP-IDF i2c HAL for ESP32 periph/i2c#18279
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Jul 17, 2022
Merged
cpu/esp32: use ESP-IDF i2c HAL for ESP32 periph/i2c#18279benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: boards
gschorcht
added
Type: enhancement
gschorcht
changed the title
gschorcht
changed the title
gschorcht
force-pushed
the
cpu/esp32/periph_hal_esp32_i2c
branch
from
6a428a3 to
e064403
Compare
gschorcht
added
CI: ready for build
benpicco
reviewed
Jul 17, 2022
Comment on lines
+353
to
+358
| uint8_t module; /**< I2C module identifier */ | ||
| i2c_speed_t speed; /**< I2C bus speed */ | ||
| gpio_t scl; /**< GPIO used as SCL pin */ | ||
| gpio_t sda; /**< GPIO used as SDA pin */ | ||
| bool scl_pullup; /**< Pullup enabled for SCL pin */ | ||
| bool sda_pullup; /**< Pullup enabled for SDA pin */ |
Contributor
There was a problem hiding this comment.
Suggested change
| uint8_t module; /**< I2C module identifier */ | |
| i2c_speed_t speed; /**< I2C bus speed */ | |
| gpio_t scl; /**< GPIO used as SCL pin */ | |
| gpio_t sda; /**< GPIO used as SDA pin */ | |
| bool scl_pullup; /**< Pullup enabled for SCL pin */ | |
| bool sda_pullup; /**< Pullup enabled for SDA pin */ | |
| gpio_t scl; /**< GPIO used as SCL pin */ | |
| gpio_t sda; /**< GPIO used as SDA pin */ | |
| uint8_t module; /**< I2C module identifier */ | |
| i2c_speed_t speed; /**< I2C bus speed */ | |
| bool scl_pullup; /**< Pullup enabled for SCL pin */ | |
| bool sda_pullup; /**< Pullup enabled for SDA pin */ |
struct packing
Contributor
Author
There was a problem hiding this comment.
It seems that the reordering does not save any byte. Should I change it anyway?
Contributor
There was a problem hiding this comment.
Hm I had hoped this might save a few bytes of ROM, but it's no big deal either way
benpicco
reviewed
Jul 17, 2022
benpicco
reviewed
Jul 17, 2022
Contributor
|
Please squash |
benpicco
approved these changes
Jul 17, 2022
Fixed delay values are replaced by calculated delays measured in CPU cycles in I2C software implementation. The advantage is that for each ESP SoC only a clock calibration offset has to be specified. The delay measured in CPU cycles are then then derived from current CPU frequency for the given bus speed. The disadvantage is that the calculated delays are not as precise as the predefined fixed delays.
gschorcht
force-pushed
the
cpu/esp32/periph_hal_esp32_i2c
branch
from
9e757f8 to
06aa8f2
Compare
Contributor
Author
|
@benpicco Thanks for reviewing and merging |
Contributor
Author
|
@benpicco This was the last PR that had to be merged to continue the work. Many thanks again for the quick review and merge of all these split-offs from PR #17841, I really appreciate it. Thanks to your reviews we were able to merge them all into the release, so we should have a consistent state of the APIs used. The only remaining PR #18260 is completely independent of the other changes in PR #17841 and can be merged later, even after the changes in PR #17842 and in conjunction with PR #17844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841 and provides the following changes:
esp_i2c_hw).This PR depends on PR #18270.Testing procedure
esp32-ci).Issues/PRs references
Split-off from PR #17841
Depends on PR #18270