cpu/esp32: use ESP-IDF ledc HAL for periph/pwm#18276
Merged
benpicco merged 4 commits intoRIOT-OS:masterfrom Jul 14, 2022
Merged
cpu/esp32: use ESP-IDF ledc HAL for periph/pwm#18276benpicco merged 4 commits intoRIOT-OS:masterfrom
benpicco merged 4 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: boards
gschorcht
added
Type: enhancement
benpicco
reviewed
Jul 13, 2022
benpicco
reviewed
Jul 13, 2022
gschorcht
force-pushed
the
cpu/esp32/periph_hal_esp32_pwm
branch
from
c24762f to
77647ea
Compare
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841 with following changes:
periph/pwmThe reason why the LEDC_PWM controller is now used instead of the MCPWM controller is that the LEDC_PWM is available on all ESP32x SoC variants while the MCPWM is only available on ESP32 and ESP32-S3. To be able to use the driver for all ESP32x SoC variants the LEDC_PWM control is used.
Testing procedure
Compile and test with
Issues/PRs references
Split-off from PR #17841