cpu/esp32: use ESP-IDF adc/dac HAL for periph/adc and periph/dac#18271
Merged
benpicco merged 4 commits intoRIOT-OS:masterfrom Jul 17, 2022
Merged
cpu/esp32: use ESP-IDF adc/dac HAL for periph/adc and periph/dac#18271benpicco merged 4 commits intoRIOT-OS:masterfrom
benpicco merged 4 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: cpu
gschorcht
added
State: waiting for other PR
gschorcht
changed the title
gschorcht
force-pushed
the
periph_hal_esp32_adc
branch
from
9e28fa5 to
0f0d534
Compare
gschorcht
added
CI: ready for build
gschorcht
changed the title
benpicco
approved these changes
Jul 17, 2022
benpicco
reviewed
Jul 17, 2022
Contributor
|
Please squash! |
gschorcht
force-pushed
the
periph_hal_esp32_adc
branch
from
a5067a7 to
43d2340
Compare
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841 and provides:
Please note: This PR initially provided only the changes for
periph/adc. However, since the changes toperiph/adcare not possible independently ofperiph/dac, the changes from PR #18272 had to be included as well. PR #18272 is therefore closed.This PR depends on PR #18270Testing procedure
Compile and test with
Issues/PRs references
Split-off from PR #17841
~Depends on PR #18270 ~
Prerequisite for PR #18272