cpu/esp32: use ESP-IDF gpio HAL for periph/gpio#18270
Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom Jul 15, 2022
Merged
cpu/esp32: use ESP-IDF gpio HAL for periph/gpio#18270benpicco merged 3 commits intoRIOT-OS:masterfrom
benpicco merged 3 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
requested review from
MichelRottleuthner,
MrKevinWeiss,
aabadie,
fjmolinas,
jia200x,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Area: cpu
gschorcht
added
Type: enhancement
gschorcht
force-pushed
the
cpu/esp32/periph_hal_esp32_gpio
branch
from
2a64946 to
77f8748
Compare
gschorcht
added
CI: ready for build
gschorcht
changed the title
benpicco
added
CI: ready for build
benpicco
reviewed
Jul 13, 2022
benpicco
reviewed
Jul 14, 2022
gschorcht
force-pushed
the
cpu/esp32/periph_hal_esp32_gpio
branch
from
ffa6e9e to
66ceaa4
Compare
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841 and provides:
Please note: The ESP-IDF gpio HAL is used in any case for the
gpio_init*functions. For the GPIO access, however, the ESP-IDF gpio HAL is only used if theesp_idf_gpio_halmodule is enabled. Otherwise, the peripheral GPIO driver still uses direct access to the GPIO input/output registers for better performance and for future implementation of thegpio_llAPI.This PR depends on PR #18261Testing procedure
Compile and test basic GPIO functionality with
Issues/PRs references
Split-off from PR #17841
Depends on PR #18261Prerequisite for PR #18271
Prerequisite for PR #18279