Skip to content

cpu/esp32: ESP32x SoC variant independent syscalls#18266

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/variant_indpependent_syscalls
Jun 28, 2022
Merged

cpu/esp32: ESP32x SoC variant independent syscalls#18266
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/variant_indpependent_syscalls

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Jun 27, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841. It contains the changes needed for compilation for all other ESP32x SoC variants. For that purpose, It also uses the ESP-IDF interrupt HAL.

Testing procedure

  1. Green CI
  2. Compile and check any simple test app, for example: 
    BOARD=esp32-wroom-32 make -j8 -C tests/shell flash term

Issues/PRs references

Split-off from PR #17841.

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 27, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jun 27, 2022
@gschorcht gschorcht requested a review from benpicco June 27, 2022 15:29
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 28, 2022
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Jun 28, 2022 •
edited
Loading

@benpicco Again a false positive due to the hashes log 😟 Could we rerun the compilation with label "CI: skip compile" to avoid a further senseless complete compilation cycle?

@benpicco benpicco added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 28, 2022
@benpicco benpicco merged commit b00810c into RIOT-OS:master Jun 28, 2022
@gschorcht gschorcht deleted the cpu/esp32/variant_indpependent_syscalls branch June 30, 2022 14:14
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2022.07

Development

Successfully merging this pull request may close these issues.

3 participants

@gschorcht @benpicco @chrysn