cpu/esp32: move platform code for Xtensa-based ESP32x SoCs to module esp_xtensa#18259
Merged
benpicco merged 5 commits intoRIOT-OS:masterfrom Jun 26, 2022
Merged
Conversation
github-actions
bot
added
Area: cpu
gschorcht
added
Type: enhancement
benpicco
reviewed
Jun 25, 2022
gschorcht
force-pushed
the
cpu/esp32/separate_xtensa_platform_code
branch
from
2805c1a to
ff4dcd6
Compare
gschorcht
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
benpicco
approved these changes
Jun 25, 2022
Contributor
Author
|
@benpicco I have introduced now a separate module |
Contributor
Author
|
@benpicco I wonder if I should rename the folder |
Contributor
|
Sure that’s more consistent |
To allow a platform independent implementation of tread_arch for different ESP32x SoC variants, the platform specific code for Xtensa based ESP SoCs is moved to a separate module `esp_xtensa`.
To allow a platform independent implementation of irq_arch for different ESP32x SoC variants, the platform specific code for Xtensa based ESP SoCs is moved to a separate module `esp_xtensa`.
To allow a platform independent implementation of exceptions for different ESP32x SoC variants, the platform specific code for Xtensa based ESP SoCs is moved to a separate platform file `exception_xtensa.c`.
gschorcht
force-pushed
the
cpu/esp32/separate_xtensa_platform_code
branch
from
ff4dcd6 to
684ed28
Compare
gschorcht
changed the title
gschorcht
force-pushed
the
cpu/esp32/separate_xtensa_platform_code
branch
from
684ed28 to
ea5d2b3
Compare
gschorcht
changed the title
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a splitt-off from PR #17841 and replaces partially PR #18247.
To allow a platform independent implementation of
tread_arch.c,irq_arch.candexception.cfor different ESP32x SoC variants, the platform specific code for Xtensa-based ESP SoCs is moved to the separate moduleesp_xtensa.** Background**
The file
thread_arch.cin moduleesp_xtensais not really independent of the used ESP SoC. Although ESP8266 and ESP32 share most of the code, that's whythread_arch.cis defined in moduleesp_xtensaincpu/esp_common, they require some SoC specific code, especially inthread_yield_*functions. These functions are something very special to ESP SoCs and not common for Xtensa cores. That is, the Xtensa code is not general enough to justify acpu/xtensa_commonfolder.Testing procedure
Issues/PRs references
Splitt-off from PR #17841 and PR #18247
Replaces PR #18247 partially