Merged
Conversation
Implements an interface for ESP-IDF types and functions that are required by RIOT-OS but cannot be included directly due to name conflicts. f
gschorcht
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: cpu
gschorcht
added
CI: ready for build
benpicco
approved these changes
Jun 25, 2022
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Makes it painfully clear why namespaces would sometimes be a good thing to have…
I hope we can enable LTO one day so this at least wouldn't add any run-time cost anymore.
Contributor
Author
|
@benpicco Can we merge this one? It should then be possible to prepare the PRs for peripherals independent of other PRs once this PR is merged. |
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
Contributor
Author
Unfortunately this is not possible after all. The function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841. It adds the basic structure for an API which is used for ESP-IDF types and functions that are required by RIOT-OS but cannot be included directly due to naming conflicts.
For this purpose, the header files of this API declare the types and functions that are required from the ESP-IDF, but without using the ESP-IDF header files to avoid conflicting names. The implementation of the API then uses the ESP-IDF. In most cases, simple wrapper functions are sufficient.
Testing procedure
Since the basic structure of the API contains almost no functionality, a green CI is sufficient.
Issues/PRs references
Split-off from PR #17841