Skip to content

cpu/esp32: ESP32x SoC variant independent makefiles#18249

Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/variant_independent_makefiles
Jun 24, 2022
Merged

cpu/esp32: ESP32x SoC variant independent makefiles#18249
benpicco merged 2 commits intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/variant_independent_makefiles

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Jun 23, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841. It provides the changes of all makefiles and Kconfigs that are necessary to allow the compilation for different ESP32x SoC variants.

Testing procedure

Green CI.

Issues/PRs references

Split-off from PR #17841

@github-actions github-actions bot added Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 23, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 23, 2022
@gschorcht gschorcht requested a review from benpicco June 23, 2022 11:36
This was referenced Jun 23, 2022
Merged
Closed
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 23, 2022
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Jun 24, 2022

It is about time that the hash problem is solved. Most compilations fail because of exactly one such error. Interesting, in this case, it has been an STM32 board log.

@benpicco The failure is again an unrelated glitch with mismatching hashes. Would it be sufficient to re-run Murdock without compile tests next time?

@benpicco benpicco added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 24, 2022
@benpicco benpicco enabled auto-merge June 24, 2022 14:40
@benpicco benpicco merged commit 1870d38 into RIOT-OS:master Jun 24, 2022
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Jun 25, 2022

@benpicco Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp32/variant_independent_makefiles branch June 25, 2022 22:53
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2022.07

Development

Successfully merging this pull request may close these issues.

3 participants

@gschorcht @benpicco @chrysn