cpu/esp32: invert MCU_* and CPU* conditionals#18248
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Jun 23, 2022
Merged
Conversation
The MCU_* conditionals are inverted so that they can be tested for ESP8266. In all other cases the MCU is any ESP32x SoC
The CPU* conditionals are inverted so that they can be tested for ESP8266. In all other cases the MCU is any ESP32x SoC
github-actions
bot
added
Area: build system
gschorcht
added
Type: enhancement
benpicco
approved these changes
Jun 23, 2022
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841. It provides the following changes to allow the compilation for different ESP32x SoC variants:
MCU_*conditionals in source code are inverted so that they can be tested forMCU_ESP8266. In all other cases the MCU is any ESP32x SoC variant.CPUconditionals inesptool.mkare inverted so that they can be tested foresp8266. In all other cases the MCU is any ESP32x SoC variant.Testing procedure
Green CI.
Issues/PRs references
Split-off from PR #17841.