cpu/esp32: Remove dependency on module libc_gettimeofday#18202
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Jun 18, 2022
Merged
cpu/esp32: Remove dependency on module libc_gettimeofday#18202benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
423ba3c to
4cf3e1a
Compare
Member
|
Build tests passed, but I'm retriggering CI with tests enabled to see that run_tests are cleared (they currently fail in unrelated builds, which AIU triggered this PR). The change looks good to me, but I don't feel sufficiently confident with the involved systems (neither the POSIX emulation nor the platform) to ack it. |
This was referenced Jun 14, 2022
benpicco
approved these changes
Jun 17, 2022
Contributor
Author
|
I had to rebase to solve the conflicts. There are no code changes. Since the problems of test runs are unrelated to this PR, I removed the label |
4cf3e1a to
4dc5e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a simple implementation of
_gettimeofday_rbased on the microsecond system timer (system_get_time_64()) without occupying a `TIMER_DEV.Since PR #18027, the ESP32 port uses the module
libc_gettimeofdayby default which enables implicitly modulesxtimerandztimer_usecwhich in turn occupiesTIMER_DEV(0).The changes in this PR
libc_gettimeofday.tests/periph_timerdue toTIMER_DEV(0)is ocuIn this implementation, the the microsecond system timer is realized on top of a peripheral timer. In future implementations of the ESP32 port, the microsecond hardware system timer will be used for that purpose.
Testing procedure
Issues/PRs references
Found in test runs in CI for #16833