gnrc_netif: move msg_queue to gnrc_netif struct#18171
Closed
benpicco wants to merge 2 commits intoRIOT-OS:masterfrom
Closed
gnrc_netif: move msg_queue to gnrc_netif struct#18171benpicco wants to merge 2 commits intoRIOT-OS:masterfrom
benpicco wants to merge 2 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
benpicco
added
the
CI: ready for build
maribu
approved these changes
Jun 7, 2022
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
ACK. Code change looks unscary. But Murdock seems to want a few Makefile.ci updated.
Contributor
Author
|
I think I'd rather shrink the netif thread stack sizes than blacklisting more boards because the memory for the queue now moved from the stack to a static allocation. |
Member
Then please go ahead. |
Member
|
Code change looks good to me, but Murdock is not yet happy |
Contributor
Author
|
#17905 now does the same, but with a handy define for the default netif stack size |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Move the netif thread message queue to the gnrc_netif struct so we don't have to allocate it on the stack (and enlarge the stack when we use a larger queue).
Testing procedure
Most drivers will now have more free stack space, cc110x and nrf24l01p_ng should stay roughly the same as they would handle this manually previously.
Issues/PRs references
alternative to #17905