Skip to content

pkg/lwip: Add basic version of netif_get/set_opt#18069

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
yarrick:lwip_netif_opt
May 9, 2022
Merged

pkg/lwip: Add basic version of netif_get/set_opt#18069
miri64 merged 3 commits intoRIOT-OS:masterfrom
yarrick:lwip_netif_opt

Conversation

@yarrick
Copy link
Copy Markdown
Contributor

@yarrick yarrick commented May 7, 2022 •
edited
Loading

Contribution description

Add basic netif get/set opt implementation for lwIP.

Only supporting getting IPv6 addresses and underlying netif options. Setting options not supported.

Testing procedure

Apply e22fe42 and f502b03, and build and flash tests/lwip (l2util module needs to be added).
The gnrc version of ifconfig then prints the lwIP netifs including IPv6 addresses, link type and channel for WiFi:

> ifconfig 
Iface  ET1  HWaddr: 24:0A:C4:E6:0E:9C  Channel: 11  Link: up 
          L2-PDU:1500  Source address length: 6
          Link type: wireless
          inet6 addr: fe80::260a:c4ff:fee6:e9c  scope: link
          inet6 addr: 2001:db8:0:0:260a:c4ff:fee6:e9c  scope: global
[..]

Issues/PRs references

Part of #9287

@yarrick yarrick requested a review from miri64 as a code owner May 7, 2022 16:49
@github-actions github-actions bot added Area: network Area: Networking Area: pkg Area: External package ports labels May 7, 2022
@benpicco benpicco requested a review from jia200x May 8, 2022 20:21
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 8, 2022
benpicco
benpicco previously approved these changes May 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A surprisingly simple addition, nice to have this now work across stacks.

@benpicco benpicco dismissed their stale review May 8, 2022 20:35

CI issues

benpicco
benpicco reviewed May 8, 2022
View reviewed changes
benpicco
benpicco reviewed May 8, 2022
View reviewed changes
@yarrick
Copy link
Copy Markdown
Contributor Author

yarrick commented May 8, 2022

Thanks. Squashing right away due to tiny size

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 9, 2022
@miri64
Copy link
Copy Markdown
Member

miri64 commented May 9, 2022

Looks like Murdock had some unrelated problems.

@miri64 miri64 enabled auto-merge May 9, 2022 08:47
benpicco
benpicco reviewed May 9, 2022
View reviewed changes
@yarrick
Copy link
Copy Markdown
Contributor Author

yarrick commented May 9, 2022

Seems like something rust-related is broken, also for another PR

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 9, 2022
@miri64 miri64 merged commit ad1c5fb into RIOT-OS:master May 9, 2022
@yarrick yarrick deleted the lwip_netif_opt branch May 10, 2022 09:04
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
@yarrick yarrick mentioned this pull request Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@jia200x jia200x Awaiting requested review from jia200x

Assignees

No one assigned

Labels

Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2022.07

Development

Successfully merging this pull request may close these issues.

4 participants

@yarrick @miri64 @benpicco @chrysn