drivers/slipdev: make use of chunked ringbuffer#18066
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jan 4, 2024
Merged
drivers/slipdev: make use of chunked ringbuffer#18066benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: drivers
Member
Any results yet? |
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
7dc1283 to
b1c19c4
Compare
Contributor
Author
So far no improvements, but also no worse than master. (I tested |
Contributor
Author
|
Uh so this turns out to fix a gnarly pktbuf corruption issue with SLIP |
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
4ed7888 to
88db0e9
Compare
kfessel
reviewed
Jul 21, 2022
kfessel
reviewed
Jul 21, 2022
kfessel
reviewed
Jul 27, 2022
Contributor
kfessel
left a comment
kfessel
left a comment
There was a problem hiding this comment.
From my POV (non-user of this driver):
- the change improves it:
reading in chunks enables the networkstack to check the size of the next chunck prior to requesting it making loss of packages less likely - and the readability (there is only one place the unescaping is done)
Contributor
|
@benpicco: you may squash and make this ready for review |
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
180a449 to
a379450
Compare
benpicco
requested review from
MrKevinWeiss,
jia200x,
leandrolanzieri and
miri64
as code owners
benpicco
added
the
CI: ready for build
benpicco
commented
Jul 27, 2022
This was referenced Aug 22, 2022
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
a379450 to
81b5247
Compare
Contributor
Author
|
All squashed now. |
benpicco
added
the
Type: bug
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
81b5247 to
9482882
Compare
miri64
previously requested changes
Oct 25, 2022
benpicco
added
CI: ready for build
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
9482882 to
db26bba
Compare
leandrolanzieri
added
CI: ready for build
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
db26bba to
fef861b
Compare
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
fef861b to
f54d381
Compare
fabian18
reviewed
Jan 1, 2024
Contributor
fabian18
left a comment
fabian18
left a comment
There was a problem hiding this comment.
Even if it may not be a performance increase,I can understand the new code better than the old code.
benpicco
force-pushed
the
slipdev-chunked_rb
branch
from
f54d381 to
1a888fe
Compare
fabian18
approved these changes
Jan 4, 2024
Contributor
There was a problem hiding this comment.
BOARD=same54-xpro UPLINK=slip make flash term (gnrc_border_router)
> ping -c 10 -s 1000 fe80::1%6
ping -c 10 -s 1000 fe80::1%6
1008 bytes from fe80::1%6: icmp_seq=0 ttl=64 time=185.192 ms
ps
1008 bytes from fe80::1%6: icmp_seq=1 ttl=64 time=185.191 ms
1008 bytes from fe80::1%6: icmp_seq=2 ttl=64 time=185.160 ms
1008 bytes from fe80::1%6: icmp_seq=3 ttl=64 time=185.192 ms
1008 bytes from fe80::1%6: icmp_seq=4 ttl=64 time=185.189 ms
1008 bytes from fe80::1%6: icmp_seq=5 ttl=64 time=185.169 ms
1008 bytes from fe80::1%6: icmp_seq=6 ttl=64 time=185.157 ms
1008 bytes from fe80::1%6: icmp_seq=7 ttl=64 time=185.172 ms
1008 bytes from fe80::1%6: icmp_seq=8 ttl=64 time=185.264 ms
1008 bytes from fe80::1%6: icmp_seq=9 ttl=64 time=185.176 ms
--- fe80::1%6 PING statistics ---
10 packets transmitted, 10 packets received, 0% packet loss
round-trip min/avg/max = 185.157/185.186/185.264 ms
> ps
pid | name | state Q | pri | stack ( used) ( free) | base addr | current
- | isr_stack | - - | - | 512 ( 256) ( 256) | 0x20000000 | 0x200001c8
1 | main | running Q | 7 | 1536 ( 936) ( 600) | 0x20000320 | 0x20000624
2 | 6lo | bl rx _ | 3 | 1024 ( 256) ( 768) | 0x20004664 | 0x20004964
3 | ipv6 | bl rx _ | 4 | 1024 ( 496) ( 528) | 0x200009fc | 0x20000c6c
4 | udp | bl rx _ | 5 | 512 ( 256) ( 256) | 0x20004a64 | 0x20004b64
5 | sam0_eth | bl anyfl _ | 2 | 896 ( 296) ( 600) | 0x20001988 | 0x20001c4c
6 | slipdev | bl anyfl _ | 2 | 896 ( 280) ( 616) | 0x20001e90 | 0x20002154
| SUM | | | 6400 ( 2776) ( 3624)
- works fine IMO
- code got cleaner
- PR has been open for a long time now and we also have been using it internally for that time
so let's have it merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Just a test to see if this can increase performance with high data ingress.
But turns out this also solves two nasty SLIP bugs:
Testing procedure
SLIP should work as before, ideally a bit better.
Issues/PRs references
alternative to #18826, #18229