boards/stm32f469i-disco: LEDX_ON LEDX_OFF mismatch#18041
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom May 2, 2022
Merged
boards/stm32f469i-disco: LEDX_ON LEDX_OFF mismatch#18041benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
cf2591c to
3f49e9b
Compare
benpicco
approved these changes
May 2, 2022
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
During tests of stm32f469i-disco I noticed that LEDX_ON and LEDX_OFF macros are mismatched.
When I looked at board manual I found that in this board LEDs are on using low signal - 4.15 Buttons and LEDs, "To light a LED a low logic state 0 should be written in the corresponding GPIO". Most (all?) STM Nucleo boards use for this purpose high signal, for example, the f429zi, 6.5 LEDs, "These user LEDs are on when the I/O is HIGH value, and are off when the I/O is LOW."
This PR fix this issue.
Testing procedure
Without PR, this sample program switch all four LEDs on.
With this PR everything is OK - LEDs remain off.
Issues/PRs references
None