cpu/esp32: always include libc_gettimeofday#18027
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Apr 28, 2022
Merged
Conversation
fjmolinas
added
the
CI: ready for build
fjmolinas
requested review from
MrKevinWeiss,
gschorcht,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: cpu
fjmolinas
added
the
Process: needs backport
fjmolinas
force-pushed
the
pr_esp32_gettimeoday
branch
from
af06abd to
a4bbb74
Compare
benpicco
approved these changes
Apr 28, 2022
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
This fixes the issue on esp32.
It doesn't appear to be required for esp8266 - that works without it.
Contributor
Author
Thanks for testing and figuring out the issue! |
Contributor
|
RIOT/cpu/esp32/ld/esp32.rom.ld Line 151 in 77382af |
Contributor
|
hm maybe that address is no longer correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Tries to fix the issue described in RIOT-OS/Release-Specs#247 (comment), I'm not sure why this does not fail more loudly, is there a
weakimplementation being used instead? Does the same thing need to be done foresp8266?Testing procedure
I sadly don't have the hardware to test maybe @benpicco could? I would want to do as in https://github.com/RIOT-OS/Release-Specs/blob/faafe7bcbaf13751b9b07cf5490a7bead13faa27/08-interop/README.md#task-13---icmpv6-echo-between-esp-and-named-internet-host-through-linux-with-6lowpan/
Issues/PRs references
#RIOT-OS/Release-Specs#247