nanocoap: use void * for payload bytes#17990
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom May 10, 2022
Merged
Conversation
benpicco
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
benpicco
added
the
Impact: minor
github-actions
bot
added
Area: CoAP
benpicco
added
the
CI: ready for build
kfessel
reviewed
Apr 22, 2022
benpicco
added
the
Type: cleanup
Contributor
Author
|
Urgh, so while this is a non-breaking change for C code, it breaks the Rust wrappers - how can this be resolved @chrysn |
fjmolinas
added
the
Process: API change
benpicco
added
the
State: waiting for other PR
chrysn
added a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
May 3, 2022
Updating to riot-sys 0.7.7 enables support for more recent C2Rust versions, and to riot-wrappers 0.7.22 unblocks [17990]. [17990]: RIOT-OS#17990
benpicco
removed
the
State: waiting for other PR
benpicco
added
CI: ready for build
maribu
approved these changes
May 10, 2022
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
ACK. This is a very sensible API change that should go unnoticed for the C callers and the Rust wrappers have apparently been updated.
maribu
removed
the
CI: ready for build
maribu
added
the
CI: ready for build
Member
|
Looks like the automerge was faster than giving the CI another spin :) Anyway, the next CI run with also test this. |
maribu
removed
the
CI: ready for build
benpicco
pushed a commit
to benpicco/RIOT
that referenced
this pull request
May 16, 2022
Updating to riot-sys 0.7.7 enables support for more recent C2Rust versions, and to riot-wrappers 0.7.22 unblocks [17990]. [17990]: RIOT-OS#17990 (cherry picked from commit ec498cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Casting payload to
(uint8_t *)or(void *)is really annoying and unnecessary.Testing procedure
No change in code output or on the caller side, just more convenient interface.
Issues/PRs references