drivers/mtd_mapper: fix read_page and write_page backend#17866
Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom Mar 26, 2022
Merged
drivers/mtd_mapper: fix read_page and write_page backend#17866benpicco merged 3 commits intoRIOT-OS:masterfrom
benpicco merged 3 commits intoRIOT-OS:masterfrom
Conversation
jue89
added
Type: bug
jue89
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
Contributor
Author
|
Thanks for your review! |
benpicco
reviewed
Mar 26, 2022
jue89
force-pushed
the
fix/mtd_mapper_backend
branch
from
9dcac90 to
6cf7e41
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the
mtd_mapperbackend forread_pageandwrite_page.The implementation uses
mtd_read_page()andmtd_write_page_raw()on the backing device. These methods return0on successful read resp. write. But the backend is expected to return the amount of read resp. written bytes.Testing procedure
Run
tests/mtd_mapper. I've added a test triggering this bug. Without this patch it'll be caught in an endless loop.Issues/PRs references